-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: read vue-i18n options from config path #1948
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
baab8be
docs: mention callbacks
ineshbose 969e60d
Merge branch 'next' of https://github.com/ineshbose/nuxt-i18n; branchβ¦
ineshbose e380f08
chore: initial commit
ineshbose 8acf162
Merge branch 'next' of https://github.com/nuxt-modules/i18n into i18nβ¦
ineshbose 56ad478
chore: progress
ineshbose 9da8fe7
chore: updating minor bits and tests
ineshbose File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import type { I18nOptions } from 'vue-i18n' | ||
|
||
// /** @type {import('@nuxtjs/i18n').I18nOptions} */ | ||
const config: I18nOptions = { | ||
legacy: false, | ||
locale: 'en', | ||
fallbackLocale: 'fr' | ||
// messages: { | ||
// ja: { | ||
// hello: 'γγγ«γ‘γ―οΌ' | ||
// } | ||
// } | ||
// fallbackLocale: { | ||
// en: ['ja', 'fr', 'en-US'], | ||
// ja: ['en', 'fr', 'ja-JP'], | ||
// fr: ['en', 'ja', 'fr-FR'] | ||
// } | ||
} | ||
|
||
export default config |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
export default { | ||
legacy: false, | ||
locale: 'en', | ||
messages: { | ||
fr: { | ||
welcome: 'Bienvenue', | ||
home: 'Accueil', | ||
profile: 'Profil', | ||
about: 'Γ propos', | ||
posts: 'Articles', | ||
dynamic: 'Dynamique', | ||
pages: { | ||
blog: { | ||
article: "Cette page d'article de blog" | ||
} | ||
} | ||
}, | ||
en: { | ||
welcome: 'Welcome', | ||
home: 'Homepage', | ||
profile: 'Profile', | ||
about: 'About us', | ||
posts: 'Posts', | ||
dynamic: 'Dynamic', | ||
pages: { | ||
blog: { | ||
article: 'This is blog article page' | ||
} | ||
} | ||
} | ||
}, | ||
fallbackLocale: 'en' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
export default { | ||
legacy: false, | ||
locale: 'en', | ||
messages: { | ||
fr: { | ||
welcome: 'Bienvenue', | ||
home: 'Accueil', | ||
profile: 'Profil' | ||
}, | ||
en: { | ||
welcome: 'Welcome', | ||
home: 'Homepage', | ||
profile: 'Profile' | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ThevueI18n
option may no longer be optional. It's recommended to autoloadi18n.config.ts
if we have a config that conforms to the convention. If we have a nonconventional config file name, we can specify it in thevueI18n
option!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, sorry, Never mind this comment.
I was misreading. π