fix: defineI18nRoute do not work client-side #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's excellent work! ❤️ |
kazupon
approved these changes
Mar 3, 2023
kazupon
added a commit
that referenced
this pull request
Jun 13, 2023
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
…1902) Co-authored-by: khaled.borghol <[email protected]>
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
…modules#1902)" (nuxt-modules#2153) This reverts commit 182098b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#1889
❓ Type of change
📚 Description
When attempting to check redirection, the detectRedirect function matches a non-defined i18n route back to the root path.
The detectRedirect function was modified to detect whether the route matched by the router is an i18n route. If it is, we will continue with the logic as-is. If it is not, we will skip redirection.
📝 Checklist