Feat: allow multiple locales under a single domain #1461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoBomfim
commented
Jun 23, 2022
| @@ -145,7 +157,11 @@ export function makeRoutes (baseRoutes, { | |||
| ) | |||
|
|
|||
| if (shouldAddPrefix) { | |||
| path = `/${locale}${path}` | |||
| path = `/${locale.code}${path}` | |||
There was a problem hiding this comment.
When running no-lang-switcher, locale.code is undefined, so I have to figure out a way of checking the type of locale (object for multiple-locales, and string for no-lang-switcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still a WIP. I'm working on implementing the feature mentioned on #1161 based on the work by lfglopes. Since there were quite a few updates after this issue first got worked on, there are some things that still need some work, as well as some refactor once I'm done.
Checklist before movinfg this PR to ready-to-review:
switchLocalePathwhen switching languages so it points tonewdomain + pathinstead ofcurrentdomain + locale-code + path.