forked from uswitch/yggdrasil
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle maintenance mode for yggdrasil #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Marchaud <[email protected]>
feat(weight-annotation): Annotation to add load-balancing weight
The new annotations got the priority, the simple 'timeout' annotation still sets the 3 timeouts but if there is, at least one of the new ones, it's overwriting the values set by the simple annotation.
Applying @Aluxima suggestion Co-authored-by: Laurent Marchaud <[email protected]>
feat(split-time): split timeout annotations into 3 different ones, make defaults configurable
Signed-off-by: Laurent Marchaud <[email protected]>
Signed-off-by: Laurent Marchaud <[email protected]>
Signed-off-by: Laurent Marchaud <[email protected]>
…esses Adds multiple envoy listener ipv4 adresses
Signed-off-by: Laurent Marchaud <[email protected]>
… domain different than the our ingress
Add healthcheck-host annotation, deduplicate redundant cluster ingresses
Aluxima
reviewed
Jun 11, 2024
…to cross informations between ingress and envoy
Aluxima
requested changes
Jun 11, 2024
Co-authored-by: Laurent Marchaud <[email protected]>
Co-authored-by: Laurent Marchaud <[email protected]>
Co-authored-by: Laurent Marchaud <[email protected]>
Co-authored-by: Laurent Marchaud <[email protected]>
Co-authored-by: Laurent Marchaud <[email protected]>
SoulKyu
commented
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty
Aluxima
approved these changes
Jun 11, 2024
SoulKyu
force-pushed
the
handle-maintenance-mode
branch
7 times, most recently
from
July 29, 2024 09:16
3620354
to
c912ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new maintenance mode :
This mode should be configured on the cluster configuration.
When a cluster is in maintenance mode :