-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make serving config compatible with numaflow-core configs #2291
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
==========================================
+ Coverage 65.49% 65.54% +0.05%
==========================================
Files 346 346
Lines 42394 42614 +220
==========================================
+ Hits 27764 27933 +169
- Misses 13560 13613 +53
+ Partials 1070 1068 -2 ☔ View full report in Codecov by Sentry. |
env::var(ENV_NUMAFLOW_SERVING_JETSTREAM_PASSWORD), | ||
) { | ||
(Ok(user), Ok(password)) => { | ||
let js_client = match js_config.auth.as_ref() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will go away eventually right? we will directly write to ISB via the pipeline framework.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for now I'm trying to get it to a working state with minimal changes.
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Closes #2280