Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make serving config compatible with numaflow-core configs #2291

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

BulkBeing
Copy link
Contributor

Closes #2280

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 67.79221% with 124 lines in your changes missing coverage. Please review.

Project coverage is 65.54%. Comparing base (10b4978) to head (8673739).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
rust/serving/src/config.rs 39.50% 49 Missing ⚠️
rust/numaflow-core/src/config/components.rs 0.00% 34 Missing ⚠️
rust/numaflow/src/main.rs 0.00% 20 Missing ⚠️
rust/serving/src/app.rs 92.47% 7 Missing ⚠️
rust/serving/src/lib.rs 0.00% 6 Missing ⚠️
rust/serving/src/app/callback.rs 82.14% 5 Missing ⚠️
rust/serving/src/app/jetstream_proxy.rs 96.66% 2 Missing ⚠️
rust/numaflow-core/src/shared/create_components.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
+ Coverage   65.49%   65.54%   +0.05%     
==========================================
  Files         346      346              
  Lines       42394    42614     +220     
==========================================
+ Hits        27764    27933     +169     
- Misses      13560    13613      +53     
+ Partials     1070     1068       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith vigith changed the title Make serving config compatible with numaflow-core configs chore: make serving config compatible with numaflow-core configs Dec 17, 2024
env::var(ENV_NUMAFLOW_SERVING_JETSTREAM_PASSWORD),
) {
(Ok(user), Ok(password)) => {
let js_client = match js_config.auth.as_ref() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will go away eventually right? we will directly write to ISB via the pipeline framework.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for now I'm trying to get it to a working state with minimal changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config management for serving to merge it with numaflow core
2 participants