Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise playwright search and facet specs. #387

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Revise playwright search and facet specs. #387

merged 1 commit into from
Sep 17, 2024

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Sep 11, 2024 •
edited
Loading

What does this do?

This work revises our playwright tests to work as-is with a few exceptions.

  • Adds a 404 spec test
  • Skips tests for work.spec.test due to timeout issue in GitHub CI (#5238 to address this has been created).
  • This does not include extending tests over chat features in search results.

How do we review?

  • Do the tests pass (or skip) without fail or timing out?
  • Is playwright a part of the git workflow?

@mathewjordan mathewjordan marked this pull request as ready for review September 11, 2024 15:07
@mathewjordan mathewjordan self-assigned this Sep 17, 2024
@mathewjordan mathewjordan merged commit 2f69b1d into deploy/staging Sep 17, 2024
3 checks passed
@mathewjordan mathewjordan deleted the preview/5188-playwright branch September 17, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdid kdid kdid approved these changes

@mbklein mbklein Awaiting requested review from mbklein

Assignees

@mathewjordan mathewjordan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathewjordan @kdid