Block sending empty messages to chat endpoint #344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Handles a scenario where empty search values were being passed to the endpoint (causing issues in the API). The
Chat
component now guards against this by checking for a search term value.How to test
question
property will never be an empty string.For developers, you can also do a quick console log, or put a breakpoint in this function to check as well:
dc-nextjs/hooks/useChatSocket.ts
Lines 63 to 67 in a6ddf55