-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Gen AI toggle tab state to localStorage #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great aside from one point of complexity. What should the user expect when the do the following?
- Check Use Generative AI
- Do their query/question, "Music"
- Click View
n
Results tab - Select any facet (Image)
Right now, this will select the facet however it will also send them back to the AI Response tab. I think this is where we keep falling back an forth. This bit of complexity makes it where we can't necessarily rely on the Checkbox solely for deciding the current tab -- but some other current state knowledge is necessary as well.
@mathewjordan I've been really trying to avoid suggested browser |
I'm all for it if it simplifies handling. |
70247b9
to
74453ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
9da6daf
to
bb9b42a
Compare
What does this do?
localStorage
This PR moves the ball down the field, however there is one last piece which I'm not sure of the proper direction?
When a user is search w/ Gen AI, switches to the View Results tab, actively filters the results, and then clicks on the "AI Response" tab, the AI stream creates a new websocket request and doesn't render the cached result. Is this an expected outcome or no? Does faceting or filtering items change the nature of the original AI response, I guess is the question.
How to test
Basically just click around the app, searching, toggling the Gen AI check box on off at various places and times. Try logging in / out, see how the UX responds. Anything which seems out of the ordinary should be noted and addressed.