Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Github flavored markdown with new NPM useMarkdown hook #335

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Support Github flavored markdown with new NPM useMarkdown hook #335

merged 1 commit into from
Jun 14, 2024

Conversation

adamjarling
Copy link
Contributor

What does this do?

Swaps out DC's custom useMarkdown hook with @nulib/use-markdown.

How to test

  • Verify search result text renders appropriate HTML from markdown
  • Verify a trailing blinking cursor is present when the chat response is actively streaming and not finished

@adamjarling adamjarling self-assigned this Jun 13, 2024
mathewjordan
mathewjordan approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@mathewjordan mathewjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Awesome, glad to see this and that it still works well with the animated cursor.

Can we wait to merge after #330?

@mathewjordan mathewjordan merged commit 7ac9895 into preview/chat-integration Jun 14, 2024
1 check passed
@mathewjordan mathewjordan deleted the 4593-gh-markdown-support branch June 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathewjordan mathewjordan mathewjordan approved these changes

Assignees

@adamjarling adamjarling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjarling @mathewjordan