Facets filter button becomes fixed only after scrolling past chat response UI elements #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse UI elements
mathewjordan
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Removes the Facets Filter button from relying upon the Fixed Search bar to trigger it's own fixed position in the center of the screen. Instead, there's now a scroll event listener, and if the Filter element gets within a range of the top of the viewport (hardcoded for now to 70px), this calculation will trigger the Filter element's position on the screen.
How to test
Perform a Chat AI search, and notice the placement of the Filter button when scrolling up and down the page.