fix: fixed tests for node

[mszmida]

This change fixes compatibility of tests with Node and Jest. Current Node LTS version is v20.13.0. On GitHub Actions we are using:

[nobkd]

Would recommend something like

import { join, dirname } from 'node:path'
import { fileURLToPath } from 'node:url'

fileURLToPath(dirname(import.meta.url))

ref: nuejs/create-nue@86034d2

---

• Use named imports. At least that's done so almost everywhere currently
• Build the paths with join() or so, so it also works on Windows
• Define fs.readFile(filepath, 'utf-8') to get a string and not a buffer (https://nodejs.org/api/fs.html#filehandlereadfileoptions)

You can copy relatively much from e.g. here: https://github.com/nuejs/nue/blob/master/packages/nuekit/test/nuekit.test.js

---

Maybe something like the following incomplete example:

import { join, dirname } from 'node:path'
import { fileURLToPath } from 'node:url'
import { promises as fs } from 'node:fs'

import { createKit } from '../src/nuekit.js'


const __dirname = fileURLToPath(dirname(import.meta.url))

// temporary directory
const root = join(__dirname, 'page-router-test')
const dist = join(root, '.dist')
const distDev = join(dist, 'dev')

// setup and teardown
beforeAll(async () => {
  await fs.rm(dist, { recursive: true, force: true })

  const nue = await createKit({ root }) // maybe not working (path problems...), but needed if not tested from root of monorepo but for this module only(?)
  await nue.build()
})

// ...

function read(filePath) {
  return fs.readFile(join(distDev, filePath), 'utf-8')
}

---

There might still be jest not defined and/or wrong environment errors...

[nobkd]

Maybe avoid jest.restoreAllMocks() if feasible and instead of jest.spyOn just spyOn
and restore the mock at the end of the test manually mocked.mockRestore()?
Just some ideas.

EDIT: (absolute) paths might be a problem with jest/... not sure, why though

[mszmida]

@nobkd Thank you for the review and hints! Currently the tests are failing because esbuild path resolution works differently on node:

export async function getBuilder(is_esbuild) {
  const actual_cwd = process.env.ACTUAL_CWD || process.cwd()
  try {
    return is_esbuild ? await import(resolve('esbuild', `file://${actual_cwd}/`)) : Bun
  } catch {
    throw 'Bundler not found. Please use Bun or install esbuild'
  }
}

I will take a look on that tomorrow.

[tipiirai]

@mszmida looks like some checks were not succesful, so I'm hesitant to merge this

[nobkd]

Yes it's not running properly currently, because something (jest or...) handles path resolution differently, I think...

---

Hidden as off-topic

@tipiirai The tests currently don't run automatically when new contributors make a pull request. I don't know if there is a way to let them run automatically regardless, or not.
But it would be great, if you would let those tests run before merging next time. I would have allowed the run, but I don't seem to have enough permissions to do so, so you'll have to do that.. :)