Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and report errors reading mergeable sources #41

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

hlship
Copy link
Contributor

@hlship hlship commented Nov 1, 2024

  • Please check if the PR fulfills these requirements
  • [ x] There is an open issue describing the problem that this pr intents to solve.
    • [x ] You have a descriptive commit message with a short title (first line).
  • [ x] Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix for #42

  • What is the current behavior?

The original exception is reported but gives no context about what file contains the parse error.

  • What is the new behavior (if this is a feature change)?

Catches exceptions when parsing mergeable files, and throws a new exception with details about what file was being read when the original exception occured.

Also, removed the spinner output, which makes reading log ouput harder.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Not a breaking change.

  • Other information:

@hlship hlship marked this pull request as ready for review November 1, 2024 18:03
@hlship hlship self-assigned this Nov 1, 2024
@hlship hlship added the bug Something isn't working label Nov 1, 2024
@alan-ghelardi
Copy link
Collaborator

Thank you again @hlship!

@alan-ghelardi alan-ghelardi merged commit aedf6fc into master Nov 4, 2024
2 checks passed
@alan-ghelardi alan-ghelardi deleted the hls/20241101-identify-bad-merge branch November 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants