Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept compiler options when building app #32

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Accept compiler options when building app #32

merged 5 commits into from
Feb 1, 2024

Conversation

miorimmax
Copy link
Contributor

@miorimmax miorimmax commented Jan 3, 2024

  • Please check if the PR fulfills these requirements
  • There is an open issue describing the problem that this pr intents to solve.
    • You have a descriptive commit message with a short title (first line).
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior?
    We don't have a mechanism to provide compiler options to the Clojure compiler.

  • What is the new behavior (if this is a feature change)?
    We can provide compiler options to the Clojure compiler using the --compiler-options OPTIONS command line argument, whose value is a map in EDN format (i.e. anything that clojure.edn/read-string can read).

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    This PR does not introduce breaking changes.

  • Other information:
    Closes: Vessel lacks a mechanism to set options for the Clojure compiler #33

@miorimmax miorimmax added the enhancement New feature or request label Jan 3, 2024
@miorimmax miorimmax marked this pull request as ready for review January 4, 2024 12:59
@miorimmax
Copy link
Contributor Author

Looks like the PR checks are not triggering for some reason, anything I should do?

Copy link
Collaborator

@alan-ghelardi alan-ghelardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'll have a look why the Action didn't trigger 😕

@alan-ghelardi
Copy link
Collaborator

I changed the workflow to trigger on pull_request events. Could you rebase onto the main branch, please? Also, most likely, you'll need to enable actions on your fork if they aren't enabled by default. Last, if possible, add a new entry to the changelog with a brief explanation about your change. Just put a new Added section under the Unreleased one. When we trigger a release, the changelog is bumped automatically.

Copy link
Collaborator

@alan-ghelardi alan-ghelardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just requesting a change in the changelog to avoid breaking the release process. The feature itself is fine.

CHANGELOG.md Outdated Show resolved Hide resolved
@alan-ghelardi alan-ghelardi merged commit f5f318c into nubank:master Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vessel lacks a mechanism to set options for the Clojure compiler
2 participants