Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to include namespaced symbols in the implicit arg symbols #40

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Allow to include namespaced symbols in the implicit arg symbols #40

merged 4 commits into from
Nov 7, 2024

Conversation

joaopluigi
Copy link
Contributor

@joaopluigi joaopluigi commented Oct 24, 2024 •
edited
Loading

2.0.1 / 2024-11-07

  • Allow implicit args for nodely syntax macros (e.g. >leaf) to include namespaces in the implicit arg symbols.

joaopluigi and others added 3 commits October 24, 2024 15:39
@joaopluigi
make question-mark->keyword use str instead of name
c14a886
@aredington
When we bind to symbols make sure the symbols aren't namespaced
b7e9efc 
- Detect when question-mark symbols are in the expr
- Generate gensyms for binding to
- Rewrite the body to replace question-mark symbols with their
  corresponding gensyms
- Bind to the (unnamespaced) gensyms in arg binding form
@aredington
lint fix
3466a55
@sovelten
Copy link
Collaborator

add changelog and bump

@joaopluigi joaopluigi marked this pull request as ready for review November 7, 2024 17:47
@joaopluigi joaopluigi changed the title Namespaced symbols Allow to include namespaced symbols in the implicit arg symbols Nov 7, 2024
aredington
aredington approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@aredington aredington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this software

@joaopluigi joaopluigi merged commit ed9624c into main Nov 7, 2024
5 checks passed
@joaopluigi joaopluigi deleted the fix-namespaced-symbols-bug branch November 7, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aredington aredington aredington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joaopluigi @sovelten @aredington