Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customize interceptors #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mateusduboli
Copy link
Contributor

Context

We have some problems with the raise interceptor that it, in conjunction with the way martian defines the interceptor stack, will always log the exception on stderr.

Explaining in more detail:

The proposed solution by the developers is to catch such exceptions before, which seems to be a good option, considering that what we are doing on OUR code is to use http status as control flow and exceptions are not actually a good driver for this.

The main issue here, is that with these exceptions always being logged on stderr causes our monitoring to be hectic as we should keep monitoring for problems there and ignoring stack traces seems to be dangerous in this situation.

Impact

I've checked the usages of the kubernetes-api.core namespace, and there does not seems to be any usage of the :interceptor parameter, even it being a breaking change, it will not have impact on our codebase.

Changelog

  • Remove usage o :refer :all in tests
  • Allow for the :interceptor parameter to override all the default interceptors of the client.

@mateusduboli mateusduboli changed the title Allow customize exceptions Allow customize interceptors Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant