Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MinMax Scaler #215

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add MinMax Scaler #215

wants to merge 6 commits into from
+154 −2

Conversation

HectorLira
Copy link
Contributor

Status

READY

Todo list

  • Documentation
  • Tests added and passed
  • Issue: closes NA

Background context

We're adding a MinMax scaler to fklearn.training module, often used in neural networks.

Description of the changes proposed in the pull request

We've made two changes:

  1. Adding the MinMax scaler to fklearn.training module.
  2. Adding tests of the MinMax scaler.

Related PRs

NA

Where should the reviewer start?

With the definition of the MinMax scaler itself.

Remaining problems or questions

NA

@HectorLira HectorLira requested a review from a team as a code owner October 25, 2022 14:41
@MarianaBlaz MarianaBlaz added the review-request Waiting to be reviewed label Oct 25, 2022
mnaR99
mnaR99 approved these changes Feb 13, 2023
View reviewed changes
Copy link

@mnaR99 mnaR99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaR99 mnaR99 mnaR99 approved these changes

Assignees
No one assigned
Labels
review-request Waiting to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HectorLira @mnaR99 @MarianaBlaz