Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce codestyle using pre-commit and some related fixes #191

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Enforce codestyle using pre-commit and some related fixes #191

wants to merge 6 commits into from
+495 −469

Conversation

erickisos
Copy link
Contributor

@erickisos erickisos commented Mar 11, 2022 •
edited
Loading

Context

This is just an attempt to enforce some "good practices" into the code by using pre-commit.
I want to know if it makes sense as of now, or if you think that it would be great to have something even more opinionated (like black)

The main reason behind something like this is to help the contributors to write code without any extra worries about "how to format the code", and "which are the specific code-style for this project".

Status

READY

Relates to #188

@erickisos erickisos requested a review from a team as a code owner March 11, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erickisos