Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread safety #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Thread safety #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbbbe3b
Make store reductions thread-safe
vmaraccini Jul 11, 2017
37cf251
Make `newState` callbacks come from the Main thread
vmaraccini Jul 11, 2017
324e191
Make state assignment protected by lock
vmaraccini Jul 11, 2017
888127f
Remove main thready newState enforcement
vmaraccini Jul 11, 2017
7506d48
Update tests
vmaraccini Jul 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ReSwift/CoreTypes/StoreSubscriber.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ extension StoreSubscriber {
// swiftlint:disable:next identifier_name
public func _newState(state: Any) {
if let typedState = state as? StoreSubscriberStateType {
DispatchQueue.main.sync {
newState(state: typedState)
}
newState(state: typedState)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove the mainThread enforcement?

Copy link
Author

@vmaraccini vmaraccini Jul 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be optional; Always calling newState in the main thread may be unnecessary, or even undesired.

}
}
}