-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): Enable e2e test #23508
base: master
Are you sure you want to change the base?
fix(node): Enable e2e test #23508
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c843839. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
be7fcdc
to
419e05c
Compare
419e05c
to
d80fd07
Compare
d80fd07
to
72421e3
Compare
72421e3
to
885f723
Compare
885f723
to
261ec16
Compare
7b2a981
to
c7f290c
Compare
let proj: string; | ||
beforeAll(() => { | ||
proj = newProject({ | ||
packages: ['@nx/node'], | ||
// npm has resolution for ajv some packages require ajv6 and some require ajv8 and npm resolves it to ajv6 (Error: Cannot find module 'ajv/dist/compile/codegen') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should at least add a //TODO to re-enable the tests for other package managers.
@jaysoo Do you know how we can either align these versions or mitigate this issue with the default options of npm?
c7f290c
to
5b213c2
Compare
5b213c2
to
c843839
Compare
Re-enables e2e tests for node
Docker changes to be merged first: #26365