Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): copy assets handler should handle ignore globs on windows #23065

Merged
merged 1 commit into from Apr 30, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

We use node:path for path operations in copy-assets-handler

Expected Behavior

We use node:path/posix to ensure paths are in the proper format for minimatch

Related Issue(s)

Fixes #23050

@AgentEnder AgentEnder requested a review from a team as a code owner April 29, 2024 13:59
@AgentEnder AgentEnder requested a review from Coly010 April 29, 2024 13:59
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 2:01pm

@AgentEnder AgentEnder merged commit c09f70f into nrwl:master Apr 30, 2024
6 checks passed
Copy link

github-actions bot commented May 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore glob on Copy Assets Handler doesn't work on Windows
2 participants