feat(core): add bun package manager

[Jordan-Hall]

Bun uses yarn lock for it's binary file. Running the binary will produce the content of a yarn lock file (v1)

Other option is to use the -y command on add and install. This will create a yarn lock file and then createLockFile can just modify the yarn.lock file instead?

This is the PR made from #19113 and pushed due to #22402 being closed.

PS Bun feels more stable since the PR was first created!

This PR will resolve #22283 and start of #21075

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	May 9, 2024 6:51pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 46516c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --targets=lint,test,build --base=6dd9455b67bb8f82b417a16f5474941f34445b76 --head=46516c8c5085542291343dfe58fd6f0c71e6f84f --parallel=3

✅ Successfully ran 6 targets

• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=6dd9455b67bb8f82b417a16f5474941f34445b76 --head=46516c8c5085542291343dfe58fd6f0c71e6f84f
• nx documentation --no-dte
• nx affected -t e2e-macos-ci --parallel=1 --base=6dd9455b67bb8f82b417a16f5474941f34445b76 --head=46516c8c5085542291343dfe58fd6f0c71e6f84f
• nx affected --targets=e2e,e2e-ci --base=2ee965042db22ae7b0276c3162daba35f5c74f4c --head=503bc40066d82a446fe1fd317f2e06f8bcb6ae93 --parallel=1
• nx affected -t e2e-macos --parallel=1 --base=2ee965042db22ae7b0276c3162daba35f5c74f4c --head=503bc40066d82a446fe1fd317f2e06f8bcb6ae93

---

Sent with 💌 from NxCloud.

[Jordan-Hall]

@edbzn Would it be worth calling stringifyYarnLockfile? But would have to edit how it is created into a file because it is a self-executable file

[Jordan-Hall]

My thinking is moving the following into a util

const lockFile = createLockFile(
      builtPackageJson,
      context.projectGraph,
      packageManager
    );
    writeFileSync(
      `${outDirRelativeToWorkspaceRoot}/${getLockFileName(packageManager)}`,
      lockFile,
      {
        encoding: 'utf-8',
      }
    );

its duplicated code but run IF check for bun and use the bun CLI to generate the binary file

[edbzn]

Worth asking @meeroslav, he knows best how to deal with lockfiles

[jaysoo]

We should reuse stringifyYarnLockfile to parse the file, as long as it handles bun-specific strings: # bun at the top, and version "workspace:<proj>" if using bun workspaces.

[meeroslav]

Since there doesn't seem to be a way to generate bun.lockb without running the install, I would use the stringifyYarnLockfile to be as close as possible to the intended package versions.

[Jordan-Hall]

I'm looking at generating the binary file. Happy to update snapshot so this can go in and work on that after? Also love to get involved in adding runtime and bun test. I have plugin that does it for now, but be nice if NX can add native support

[Jordan-Hall]

@jaysoo If you want to make the yarn.lock a follow up then I think this PR is completed?

[laynef]

I reused Yarn in my PR bro. They still had problems with it. The people want Bun support!

If it builds and runs, then that's a start.

Help us brothers out for taking the time to do this for you.

It was my birthday btw when I built a working version for your project.

[Jordan-Hall]

This is different, this is to handle the manual creation of lock files not the reading of the lock file. Nx team doing a great job BTW, they been so many unstable issues. The chunk of this was taken from my PR back in Sep 11, 2023. But I closed it due to Bun having too many bugs

[Jordan-Hall]

@laynef you can always use nx-bun to get started for now

[Jordan-Hall]

cc: @JamesHenry

[Jordan-Hall]

I was working in WSL. I'll fix the test in the morning on my Linux laptop

[JamesHenry]

Thanks a lot for this @Jordan-Hall!

We will need some e2e coverage in addition to the comments

[Jordan-Hall]

So latest pr revase broke it again -_- let me know when you want this in / ready and I'll fix it again.

[jaysoo]

So latest pr revase broke it again -_- let me know when you want this in / ready and I'll fix it again.

Looks like it's green now. I'll do more testing on it, it looked good during my last test. If it's good, we can probably get it in for Nx 19.

[Jordan-Hall]

So latest pr revase broke it again -_- let me know when you want this in / ready and I'll fix it again.

Looks like it's green now. I'll do more testing on it, it looked good during my last test. If it's good, we can probably get it in for Nx 19.

Thank you. Let me know if you find any issues. Next stop bun executors 😅

[enaluz]

Is there an ETA on when this can be merged in and be usable? I'm starting a new React/React Native project for my company this week or next and I really want to use Bun + Nx 👀

If I decided to go with an alternative package manager just to get the project started (like pnpm for example), would it involve significant overhead to switch over to Bun?

[mehrangta]

Is there an ETA on when this can be merged in and be usable? I'm starting a new React/React Native project for my company this week or next and I really want to use Bun + Nx 👀

If I decided to go with an alternative package manager just to get the project started (like pnpm for example), would it involve significant overhead to switch over to Bun?

As far as I know, bun cannot change pnpm lockfile to bun lockfile. so I would choose classic npm to start with. (also workspaces in pnpm are a little bit different too)

[jaysoo]

Pushed one more fix and doing more testing. We're ready to merge Nx 19 features, so we should be merging this very soon.

[jaysoo]

Quick update on this PR, we are planning to include this in Nx 19.1 rather than 19. The reason is that Nx 19 is a stability release to address some issues around Project Crystal, so we're pushing some new features to Nx 19.1, including Bun.