Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devkit): fix failing devkit test for convertNxExecutor #22398

Merged
merged 1 commit into from Mar 19, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 19, 2024

This PR fixes a failing unit test in devkit for convertNxExecutor. The failure is caused by loading plugins from root nx.json (which are not needed for the test), which lead to unexpected export keyword from being run by Jest.

Current Behavior

Unit test is failing: https://staging.nx.app/runs/AhXfo7gza6/task/devkit%3Atest

Expected Behavior

Unit test passes

Related Issue(s)

Fixes #

@jaysoo jaysoo marked this pull request as ready for review March 19, 2024 18:19
@jaysoo jaysoo requested a review from a team as a code owner March 19, 2024 18:19
@jaysoo jaysoo requested a review from AgentEnder March 19, 2024 18:19
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Mar 19, 2024 6:19pm

@FrozenPandaz FrozenPandaz merged commit d058c8c into master Mar 19, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix_failing_devkit_test branch March 19, 2024 18:55
arekkubaczkowski pushed a commit to arekkubaczkowski/nx that referenced this pull request Mar 19, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants