fix(release): fix default renderer resolution to be relative within t… #22331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d4c8b27. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
JamesHenry
approved these changes
Mar 15, 2024
JamesHenry
requested changes
Mar 15, 2024
FrozenPandaz
force-pushed
the
fix-default-renderer-resolution
branch
from
b11b753
to
d90c4d9
Compare
JamesHenry
approved these changes
Mar 15, 2024
FrozenPandaz
force-pushed
the
fix-default-renderer-resolution
branch
from
d90c4d9
to
3c1333d
Compare
FrozenPandaz
force-pushed
the
fix-default-renderer-resolution
branch
from
3c1333d
to
d4c8b27
Compare
arekkubaczkowski
pushed a commit
to arekkubaczkowski/nx
that referenced
this pull request
Mar 19, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he package
Current Behavior
The default renderer is specified as an absolute path which can get resolved to a different version of Nx.
For the nx repo, this is the typescript code.
Expected Behavior
The default renderer is specified as a relative path which is always within the same package release is being run with.
Related Issue(s)
Fixes #