bintools improvement / gapfill #2332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specific gap fill Deprecate BUILD_NO_GAP_FILL as it gives a false impression that gap filling can be disabled in binary files. Binary files are always gap filled due to the fact they contain no address information. Only option for binary files is to control the gap fill pattern. When no gap fill is enabled in binary files, then a default pattern is used by the tool, which usually is 0x00. Generally the pattern 0x00 leads to unnecessary flash writes, as a flash generally contains 0xFF after an erase. Therefore provide a gap fill pattern Kconfig setting instead, with default value of 0xFF. For hex-files, intel hex and s19, then gap filling is generally not needed but in order to still support cases where gap filling is required then this commit introduces BUILD_OUTPUT_HEX_GAP_FILL and BUILD_OUTPUT_S19_GAP_FILL. Both settings are disabled per default. Signed-off-by: Torsten Rasmussen <[email protected]> (cherry picked from commit 2e8868c16e5ecfab8e823096892e02dac037c222)
The llvm-objcopy doesn't support a gap-fill argument, therefore clear the property to remove the error: > llvm-objcopy: error: unknown argument '--gap-fill' Signed-off-by: Torsten Rasmussen <[email protected]> (cherry picked from commit 71fd4d9c98c7fe0845b70693e8daea46c6646b80)
nordicjm
approved these changes
Dec 3, 2024
|
we aren't going to use llvm until after v2.9, does it need to have 2.9 milestone? |
this has nothing to do with Zephyr SDK LLVM. This is an improvement to existing infrastructure. |
jukkar
approved these changes
Dec 4, 2024
thst-nordic
approved these changes
Dec 4, 2024
|
sounds good. I see it also went into v2.8-branch. |
|
closing, included in #2336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bintools improvement / gapfill