[nrf noup] samples: mgmt: mcumgr: smp_svr: Add nrf5340dk-optimised sample #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mple Adds a configuration to this sample that is optimised for testing/usage with the nRF5340 which enables the Bluetooth transport, enables most management groups, has a static partition manager file with secondary partitions on QSPI flash, configures MCUboot in overwrite only mode with network core update support Signed-off-by: Jamie McCrae <[email protected]>
nvlsianpu
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Multiple board configuration/overlay files was added in the sample's sysbuild/mcuboot/boards directory as well (not only nRF540dk).
I see that many of the can be involved into the build configuration as I'm recognizing them as their copies from MCUBoot's repository.
- What intention behind that?
- Why 3-rd party board files are added?
- Should we remove original files from MCUboot's repository?
So that this sample can be used with any (nordic-based) board still, as the files in MCUboot will not be used
As above, only nordic-based boards are added
No |
|
Would add that this is only need due to, yet again, partition manager |
nvlsianpu
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration to this sample that is optimised for testing/usage with the nRF5340 which enables the Bluetooth transport, enables most management groups, has a static partition manager file with secondary partitions on QSPI flash, configures MCUboot in overwrite only mode with network core update support