-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf noup] drivers: pinctrl: Add SDP MSPI pin configuration #2260
base: main
Are you sure you want to change the base?
Conversation
4e5d7cd
to
6303428
Compare
6303428
to
5e9326e
Compare
- api | ||
harness: ztest | ||
platform_allow: | ||
- nrf54l15dk_nrf54l15_cpuapp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nrf54l15dk_nrf54l15_cpuapp->nrf54l15dk/nrf54l15/cpuapp
platform_allow: | ||
- nrf54l15dk_nrf54l15_cpuapp | ||
integration_platforms: | ||
- nrf54l15dk_nrf54l15_cpuapp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nrf54l15dk_nrf54l15_cpuapp->nrf54l15dk/nrf54l15/cpuapp
sdp_mspi: sdp_mspi@5004c000 { | ||
mspi_device: mspi_device@0 { | ||
status = "okay"; | ||
compatible = "zephyr,mspi-emul-device"; | ||
reg = <0x0>; | ||
mspi-max-frequency = <48000000>; | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned offline, this redefinition is needed because those lines:
https://github.com/nrfconnect/sdk-nrf/pull/18893/files#diff-46fdf8d2608e604b87bd6b25d0cb3243ecc117f0d63f536def7c8e8532a09c41R87-R94
are applied only after this file.
I will look into how this could be solved, until now it would be nice to add a comment here about the issue.
@@ -51,13 +51,17 @@ static struct mspi_dev_cfg device_cfg[] = { | |||
DT_FOREACH_CHILD_STATUS_OKAY_SEP(MSPI_BUS_NODE, MSPI_DEVICE_CONFIG_DT, (,)) | |||
}; | |||
|
|||
#if CONFIG_MSPI_XIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you post those changes in upstream?
@@ -15,3 +15,19 @@ tests: | |||
- apollo3p_evb | |||
integration_platforms: | |||
- native_sim | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be placed in /twister/alt
in sdk-nrf, like gpio
dir = NRF_GPIO_PIN_DIR_OUTPUT; | ||
input = NRF_GPIO_PIN_INPUT_CONNECT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any expectations in VIO regarding pre-configuration by GPIO peripheral?
I'm wondering about the nrf_gpio_pin_write
and nrf_gpio_cfg
below.
Configure SDP MSPI pins to switch their control to VPR core Signed-off-by: Jakub Zymelka <[email protected]>
Add SDP MPSI testcase to basic API test. Signed-off-by: Jakub Zymelka <[email protected]>
5e9326e
to
89ff635
Compare
Changes needed to implement SDP MSPI version.