Skip to content

[WIP] Pull in global hsfll clock device driver #7679

[WIP] Pull in global hsfll clock device driver

[WIP] Pull in global hsfll clock device driver #7679

Triggered via pull request November 27, 2024 21:01
Status Success
Total duration 2m 28s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
2m 19s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 error, 1 warning, and 9 notices
Run compliance checks on patch series (PR)
Process completed with exit code 1.
Run compliance checks on patch series (PR): ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: -#define GLOBAL_HSFLL_CLOCK_FREQUENCIES \ - DT_INST_PROP(0, supported_clock_frequencies) - -#define GLOBAL_HSFLL_CLOCK_FREQUENCIES_IDX(idx) \ +#define GLOBAL_HSFLL_CLOCK_FREQUENCIES DT_INST_PROP(0, supported_clock_frequencies) + +#define GLOBAL_HSFLL_CLOCK_FREQUENCIES_IDX(idx) \ DT_INST_PROP_BY_IDX(0, supported_clock_frequencies, idx) -#define GLOBAL_HSFLL_CLOCK_FREQUENCIES_SIZE \ - DT_INST_PROP_LEN(0, supported_clock_frequencies) - -#define GLOBAL_HSFLL_FREQ_REQ_TIMEOUT \ - K_MSEC(CONFIG_CLOCK_CONTROL_NRF2_GLOBAL_HSFLL_TIMEOUT_MS) +#define GLOBAL_HSFLL_CLOCK_FREQUENCIES_SIZE DT_INST_PROP_LEN(0, supported_clock_frequencies) + +#define GLOBAL_HSFLL_FREQ_REQ_TIMEOUT K_MSEC(CONFIG_CLOCK_CONTROL_NRF2_GLOBAL_HSFLL_TIMEOUT_MS) File:drivers/clock_control/clock_control_nrf2_global_hsfll.c Line:27 You may want to run clang-format on this change: - ? global_hsfll_get_max_clock_frequency(dev) - : spec->frequency; + ? global_hsfll_get_max_clock_frequency(dev) + : spec->frequency; File:drivers/clock_control/clock_control_nrf2_global_hsfll.c Line:77 You may want to run clang-format on this change: -static int api_request_global_hsfll(const struct device *dev, - const struct nrf_clock_spec *spec, +static int api_request_global_hsfll(const struct device *dev, const struct nrf_clock_spec *spec, File:drivers/clock_control/clock_control_nrf2_global_hsfll.c Line:92 You may want to run clang-format on this change: -static int api_release_global_hsfll(const struct device *dev, - const struct nrf_clock_spec *spec) +static int api_release_global_hsfll(const struct device *dev, const struct nrf_clock_spec *spec) File:drivers/clock_control/clock_control_nrf2_global_hsfll.c Line:105 You may want to run clang-format on this change: - .std_api = { - .on = api_nosys_on_off, - .off = api_nosys_on_off, - }, + .std_api = + { + .on = api_nosys_on_off, + .off = api_nosys_on_off, + }, File:drivers/clock_control/clock_control_nrf2_global_hsfll.c Line:133 You may want to run clang-format on this change: - rc = clock_config_init(&dev_data->clk_cfg, - ARRAY_SIZE(dev_data->clk_cfg.onoff), + rc = clock_config_init(&dev_data->clk_cfg, ARRAY_SIZE(dev_data->clk_cfg.onoff), File:drivers/clock_control/clock_control_nrf2_global_hsfll.c Line:226 You may want to run clang-format on this change: -static const struct global_hsfll_dev_config driver_config = { - GLOBAL_HSFLL_CLOCK_FREQUENCIES -}; - -DEVICE_DT_INST_DEFINE( - 0, - global_hfsll_init, - NULL, - &driver_data, - &driver_config, - PRE_KERNEL_1, - CONFIG_CLOCK_CONTROL_INIT_PRIORITY, - &driver_api -); +static const struct global_hsfll_dev_config driver_config = {GLOBAL_HSFLL_CLOCK_FREQUENCIES}; + +DEVICE_DT_INST_DEFINE(0, global_hfsll_init, NULL, &driver_data, &driver_config, PRE_KERNEL_1, + CONFIG_CLOCK_CONTROL_INIT_PRIORITY, &driver_api); File:drivers/clock_control/clock_control_nrf2_global_hsfll.c Line:260 You may want to run clang-format on this change: -#define GLOBAL_HSFLL_MIN_FREQ_HZ \ - CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_MIN_FREQ_HZ +#define GLOBAL_HSFLL_MIN_FREQ_HZ CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_MIN_FREQ_HZ -#define NRFS_BACKEND_TIMEOUT \ - K_MSEC(CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_TIMEOUT_MS) +#define NRFS_BACKEND_TIMEOUT K_MSEC(CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_TIMEOUT_MS) -#define GLOBAL_HSFLL_REQUEST_TIMEOUT_MS \ - CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_TIMEOUT_MS +#define GLOBAL_HSFLL_REQUEST_TIMEOUT_MS CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_TIMEOUT_MS File:soc/nordic/nrf54h/global_hsfll.c Line:22 You may want to run clang-format on this change: - GLOBAL_HSFLL_REQUEST_TIMEOUT_MS, - k_msleep(1)); + GLOBAL_HSFLL_REQUEST_TIMEOUT_MS, k_msleep(1)); File:soc/nordic/nrf54h/global_hsfll.c Line:48
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf2_global_hsfll.c#L27
drivers/clock_control/clock_control_nrf2_global_hsfll.c:27 -#define GLOBAL_HSFLL_CLOCK_FREQUENCIES \ - DT_INST_PROP(0, supported_clock_frequencies) - -#define GLOBAL_HSFLL_CLOCK_FREQUENCIES_IDX(idx) \ +#define GLOBAL_HSFLL_CLOCK_FREQUENCIES DT_INST_PROP(0, supported_clock_frequencies) + +#define GLOBAL_HSFLL_CLOCK_FREQUENCIES_IDX(idx) \ DT_INST_PROP_BY_IDX(0, supported_clock_frequencies, idx) -#define GLOBAL_HSFLL_CLOCK_FREQUENCIES_SIZE \ - DT_INST_PROP_LEN(0, supported_clock_frequencies) - -#define GLOBAL_HSFLL_FREQ_REQ_TIMEOUT \ - K_MSEC(CONFIG_CLOCK_CONTROL_NRF2_GLOBAL_HSFLL_TIMEOUT_MS) +#define GLOBAL_HSFLL_CLOCK_FREQUENCIES_SIZE DT_INST_PROP_LEN(0, supported_clock_frequencies) + +#define GLOBAL_HSFLL_FREQ_REQ_TIMEOUT K_MSEC(CONFIG_CLOCK_CONTROL_NRF2_GLOBAL_HSFLL_TIMEOUT_MS)
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf2_global_hsfll.c#L77
drivers/clock_control/clock_control_nrf2_global_hsfll.c:77 - ? global_hsfll_get_max_clock_frequency(dev) - : spec->frequency; + ? global_hsfll_get_max_clock_frequency(dev) + : spec->frequency;
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf2_global_hsfll.c#L92
drivers/clock_control/clock_control_nrf2_global_hsfll.c:92 -static int api_request_global_hsfll(const struct device *dev, - const struct nrf_clock_spec *spec, +static int api_request_global_hsfll(const struct device *dev, const struct nrf_clock_spec *spec,
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf2_global_hsfll.c#L105
drivers/clock_control/clock_control_nrf2_global_hsfll.c:105 -static int api_release_global_hsfll(const struct device *dev, - const struct nrf_clock_spec *spec) +static int api_release_global_hsfll(const struct device *dev, const struct nrf_clock_spec *spec)
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf2_global_hsfll.c#L133
drivers/clock_control/clock_control_nrf2_global_hsfll.c:133 - .std_api = { - .on = api_nosys_on_off, - .off = api_nosys_on_off, - }, + .std_api = + { + .on = api_nosys_on_off, + .off = api_nosys_on_off, + },
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf2_global_hsfll.c#L226
drivers/clock_control/clock_control_nrf2_global_hsfll.c:226 - rc = clock_config_init(&dev_data->clk_cfg, - ARRAY_SIZE(dev_data->clk_cfg.onoff), + rc = clock_config_init(&dev_data->clk_cfg, ARRAY_SIZE(dev_data->clk_cfg.onoff),
You may want to run clang-format on this change: drivers/clock_control/clock_control_nrf2_global_hsfll.c#L260
drivers/clock_control/clock_control_nrf2_global_hsfll.c:260 -static const struct global_hsfll_dev_config driver_config = { - GLOBAL_HSFLL_CLOCK_FREQUENCIES -}; - -DEVICE_DT_INST_DEFINE( - 0, - global_hfsll_init, - NULL, - &driver_data, - &driver_config, - PRE_KERNEL_1, - CONFIG_CLOCK_CONTROL_INIT_PRIORITY, - &driver_api -); +static const struct global_hsfll_dev_config driver_config = {GLOBAL_HSFLL_CLOCK_FREQUENCIES}; + +DEVICE_DT_INST_DEFINE(0, global_hfsll_init, NULL, &driver_data, &driver_config, PRE_KERNEL_1, + CONFIG_CLOCK_CONTROL_INIT_PRIORITY, &driver_api);
You may want to run clang-format on this change: soc/nordic/nrf54h/global_hsfll.c#L22
soc/nordic/nrf54h/global_hsfll.c:22 -#define GLOBAL_HSFLL_MIN_FREQ_HZ \ - CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_MIN_FREQ_HZ +#define GLOBAL_HSFLL_MIN_FREQ_HZ CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_MIN_FREQ_HZ -#define NRFS_BACKEND_TIMEOUT \ - K_MSEC(CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_TIMEOUT_MS) +#define NRFS_BACKEND_TIMEOUT K_MSEC(CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_TIMEOUT_MS) -#define GLOBAL_HSFLL_REQUEST_TIMEOUT_MS \ - CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_TIMEOUT_MS +#define GLOBAL_HSFLL_REQUEST_TIMEOUT_MS CONFIG_SOC_NRF54H20_GLOBAL_HSFLL_TIMEOUT_MS
You may want to run clang-format on this change: soc/nordic/nrf54h/global_hsfll.c#L48
soc/nordic/nrf54h/global_hsfll.c:48 - GLOBAL_HSFLL_REQUEST_TIMEOUT_MS, - k_msleep(1)); + GLOBAL_HSFLL_REQUEST_TIMEOUT_MS, k_msleep(1));

Artifacts

Produced during runtime
Name Size
compliance.xml
1.4 KB