lib: nrf_cloud: use BLOCK2 for resumption offset #19441

maxd-nordic · 2024-12-11T14:24:37Z

Fix an issue where resumption wasn't requesting the correct offset of the FOTA file to download using COAP.
This patch uses the standard offset option instead of a custom one.

NordicBuilder · 2024-12-11T14:33:52Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 63441eeecf658a9b76ba29fee7ebca54959e8492

more details

sdk-nrf:

PR head: 63441eeecf658a9b76ba29fee7ebca54959e8492
merge base: ffa08e9d4e592eaf079eb6f9dccfe14ec9d50bf5
target head (main): 4c6ab4d0e83046e0040f82a507bfd6826f0f4d9e
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (1)

subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── src
│  │  │  │  │  │ nrf_cloud_download.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 359
✅ Integration tests
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
- ✅ test-fw-nrfconnect-nrf-iot_thingy91
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ✅ test-fw-nrfconnect-nrf-iot_positioning
- ⚠️ test-fw-nrfconnect-nrf-iot_cloud

Disabled integration tests

- desktop52_verification
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

divipillai · 2024-12-11T14:41:57Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

+
+  * Fixed:
+
+    * An issue that would cause resumption to fail when FOTA images are downloaded using the CoAP backend.


Please remove this changelog entry and add a comment on the 2.9 release notes PR - #19240.

Took out the entry from the 2.9 release notes.

Fix an issue where resumption wasn't requesting the correct offset of the FOTA file to download using COAP. This patch uses the standard offset option instead of a custom one. Signed-off-by: Maximilian Deubel <[email protected]>

NordicBuilder · 2024-12-11T14:59:47Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

maxd-nordic · 2024-12-11T20:31:10Z

@jtguggedal @plskeggs this is unreliable for some reason - please check

plskeggs · 2024-12-13T00:36:01Z

@jtguggedal I looked at the PR and am concerned about the manual manipulation of the block2 option when the coap_client can further modify it. Back when Justin implemented this we discussed doing so but upstream in Jira issue NRFCDP-423.

My testing of this PR using the nrf_cloud_multi_service sample fails. I will put more detail in CIA-1400.

plskeggs · 2024-12-13T01:04:05Z

@maxd-nordic @jtguggedal I think the easiest fix for NCS 2.9.0 is to revert the change which made CoAP downloads the default for the nRF Cloud libraries:
4b6848d

And then post 2.9.0 make the required upstream improvement to provide official support for this and fully debug it.

jtguggedal · 2024-12-13T07:33:05Z

@maxd-nordic @jtguggedal I think the easiest fix for NCS 2.9.0 is to revert the change which made CoAP downloads the default for the nRF Cloud libraries: 4b6848d

And then post 2.9.0 make the required upstream improvement to provide official support for this and fully debug it.

I agree, it's problably better. For now I added a known issue for it, which anyway applies to v2.8.0: #19231 (comment) . I'll leave it to you guys in the nRF Cloud team to decide on and make the needed fixes for v2.9.0.

shanthanordic · 2024-12-13T10:28:05Z

not ready for RC-2 cleared milestone.

github-actions · 2025-01-15T00:32:56Z

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

maxd-nordic requested a review from a team as a code owner December 11, 2024 14:24

maxd-nordic requested a review from plskeggs December 11, 2024 14:24

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 11, 2024

maxd-nordic requested a review from jtguggedal December 11, 2024 14:24

maxd-nordic added this to the 2.9.0 milestone Dec 11, 2024

maxd-nordic added the bug Something isn't working label Dec 11, 2024

jtguggedal added bugfix Fixes a known bug and removed bug Something isn't working labels Dec 11, 2024

jtguggedal added the backport v2.9-branch auto-create a PR with same commits to v2.9-branch label Dec 11, 2024

maxd-nordic force-pushed the nrf-cloud-coap-offset-block2 branch from 1a039c9 to 6fe31c4 Compare December 11, 2024 14:38

maxd-nordic requested a review from a team as a code owner December 11, 2024 14:38

github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 11, 2024

maxd-nordic force-pushed the nrf-cloud-coap-offset-block2 branch from 6fe31c4 to 5ef78d3 Compare December 11, 2024 14:40

divipillai reviewed Dec 11, 2024

View reviewed changes

maxd-nordic mentioned this pull request Dec 11, 2024

doc: Add release notes for the 2.9.0 release #19240

Merged

5 tasks

lib: nrf_cloud: use BLOCK2 for resumption offset

63441ee

Fix an issue where resumption wasn't requesting the correct offset of the FOTA file to download using COAP. This patch uses the standard offset option instead of a custom one. Signed-off-by: Maximilian Deubel <[email protected]>

maxd-nordic force-pushed the nrf-cloud-coap-offset-block2 branch from 5ef78d3 to 63441ee Compare December 11, 2024 14:45

github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed doc-required PR must not be merged without tech writer approval. labels Dec 11, 2024

jtguggedal added the DNM label Dec 12, 2024

gregersrygg approved these changes Dec 12, 2024

View reviewed changes

divipillai approved these changes Dec 12, 2024

View reviewed changes

shanthanordic removed this from the 2.9.0 milestone Dec 13, 2024

shanthanordic removed the backport v2.9-branch auto-create a PR with same commits to v2.9-branch label Dec 13, 2024

github-actions bot added the Stale label Jan 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: nrf_cloud: use BLOCK2 for resumption offset #19441

lib: nrf_cloud: use BLOCK2 for resumption offset #19441

maxd-nordic commented Dec 11, 2024

NordicBuilder commented Dec 11, 2024 •

edited

Loading

divipillai Dec 11, 2024

peknis Dec 13, 2024 •

edited

Loading

NordicBuilder commented Dec 11, 2024

maxd-nordic commented Dec 11, 2024 •

edited

Loading

plskeggs commented Dec 13, 2024

plskeggs commented Dec 13, 2024 •

edited

Loading

jtguggedal commented Dec 13, 2024

shanthanordic commented Dec 13, 2024

github-actions bot commented Jan 15, 2025


		* Fixed:

		* An issue that would cause resumption to fail when FOTA images are downloaded using the CoAP backend.

lib: nrf_cloud: use BLOCK2 for resumption offset #19441

Are you sure you want to change the base?

lib: nrf_cloud: use BLOCK2 for resumption offset #19441

Conversation

maxd-nordic commented Dec 11, 2024

NordicBuilder commented Dec 11, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

divipillai Dec 11, 2024

Choose a reason for hiding this comment

peknis Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

NordicBuilder commented Dec 11, 2024

maxd-nordic commented Dec 11, 2024 • edited Loading

plskeggs commented Dec 13, 2024

plskeggs commented Dec 13, 2024 • edited Loading

jtguggedal commented Dec 13, 2024

shanthanordic commented Dec 13, 2024

github-actions bot commented Jan 15, 2025

NordicBuilder commented Dec 11, 2024 •

edited

Loading

peknis Dec 13, 2024 •

edited

Loading

maxd-nordic commented Dec 11, 2024 •

edited

Loading

plskeggs commented Dec 13, 2024 •

edited

Loading