Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: nrf_cloud: use BLOCK2 for resumption offset #19441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: nrf_cloud: use BLOCK2 for resumption offset #19441

wants to merge 1 commit into from
+45 −13

Conversation

maxd-nordic
Copy link
Contributor

Fix an issue where resumption wasn't requesting the correct offset of the FOTA file to download using COAP.
This patch uses the standard offset option instead of a custom one.

@maxd-nordic maxd-nordic requested a review from a team as a code owner December 11, 2024 14:24
@maxd-nordic maxd-nordic requested a review from plskeggs December 11, 2024 14:24
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 11, 2024
@maxd-nordic maxd-nordic added this to the 2.9.0 milestone Dec 11, 2024
@maxd-nordic maxd-nordic added the bug Something isn't working label Dec 11, 2024
@jtguggedal jtguggedal added bugfix Fixes a known bug and removed bug Something isn't working labels Dec 11, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 11, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 63441eeecf658a9b76ba29fee7ebca54959e8492

more details

sdk-nrf:

PR head: 63441eeecf658a9b76ba29fee7ebca54959e8492
merge base: ffa08e9d4e592eaf079eb6f9dccfe14ec9d50bf5
target head (main): 4c6ab4d0e83046e0040f82a507bfd6826f0f4d9e
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── src
│  │  │  │  │  │ nrf_cloud_download.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 359
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@jtguggedal jtguggedal added the backport v2.9-branch auto-create a PR with same commits to v2.9-branch label Dec 11, 2024
@maxd-nordic maxd-nordic force-pushed the nrf-cloud-coap-offset-block2 branch from 1a039c9 to 6fe31c4 Compare December 11, 2024 14:38
@maxd-nordic maxd-nordic requested a review from a team as a code owner December 11, 2024 14:38
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 11, 2024
@maxd-nordic maxd-nordic force-pushed the nrf-cloud-coap-offset-block2 branch from 6fe31c4 to 5ef78d3 Compare December 11, 2024 14:40
divipillai
divipillai reviewed Dec 11, 2024
View reviewed changes
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated

* Fixed:

* An issue that would cause resumption to fail when FOTA images are downloaded using the CoAP backend.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this changelog entry and add a comment on the 2.9 release notes PR - #19240.

@maxd-nordic maxd-nordic mentioned this pull request Dec 11, 2024
Open
5 tasks
@maxd-nordic
lib: nrf_cloud: use BLOCK2 for resumption offset
63441ee 
Fix an issue where resumption wasn't requesting the correct offset
of the FOTA file to download using COAP.
This patch uses the standard offset option instead of a custom one.

Signed-off-by: Maximilian Deubel <[email protected]>
@maxd-nordic maxd-nordic force-pushed the nrf-cloud-coap-offset-block2 branch from 5ef78d3 to 63441ee Compare December 11, 2024 14:45
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed doc-required PR must not be merged without tech writer approval. labels Dec 11, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@maxd-nordic
Copy link
Contributor Author

maxd-nordic commented Dec 11, 2024 •
edited
Loading

@jtguggedal @plskeggs this is unreliable for some reason - please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divipillai divipillai divipillai left review comments

@plskeggs plskeggs Awaiting requested review from plskeggs

@jtguggedal jtguggedal Awaiting requested review from jtguggedal

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backport v2.9-branch auto-create a PR with same commits to v2.9-branch bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maxd-nordic @NordicBuilder @divipillai @jtguggedal