samples: matter: Added system off configuration for smoke CO alarm #19244

kkasperczyk-no · 2024-12-04T10:45:19Z

Added configuration that allows to enable system off for the smoke CO alarm.

NordicBuilder · 2024-12-04T10:49:22Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 3f9e7a6b5194ca81bc4de2f13419cdb53e41db66

more details

sdk-nrf:

PR head: 3f9e7a6b5194ca81bc4de2f13419cdb53e41db66
merge base: eaa215e9051d05c5c399739f51a7124affbcd546
target head (main): 90ac4ed82133568e784a93dcbc85a82a48354e49
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (7)

doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── matter
│  │  ├── light_switch
│  │  │  ├── snippets
│  │  │  │  ├── lit_icd
│  │  │  │  │  │ lit_icd.conf
│  │  ├── smoke_co_alarm
│  │  │  ├── Kconfig
│  │  │  ├── README.rst
│  │  │  ├── overlay-system_off.conf
│  │  │  ├── src
│  │  │  │  ├── app_task.cpp
│  │  │  │  │ app_task.h

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 123
❌ Integration tests
- ❌ test-fw-nrfconnect-chip

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-12-04T11:12:31Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

adigie · 2024-12-04T11:13:11Z

samples/matter/smoke_co_alarm/Kconfig

+config SYSTEM_OFF
+	bool "Enable system off on idle"
+	depends on POWEROFF
+	depends on SOC_NRF54L15_CPUAPP


Do we want to support this on L05 or L10?

For L05, definitely not, but maybe for L10. I will change it to SOC_SERIES_NRF54LX

nordicjm · 2024-12-04T11:27:45Z

samples/matter/smoke_co_alarm/Kconfig

@@ -5,6 +5,16 @@
 #
 mainmenu "Matter nRF Connect Smoke CO Alarm Example Application"

+config SYSTEM_OFF


would prefer this to have a prefix e.g. APPLICATION_SYSTEM_OFF because without a prefix, it just seems like this could easily conflict with something in zephyr in future

Added configuration that allows to enable system off for the smoke CO alarm. Signed-off-by: Kamil Kasperczyk <[email protected]>

peknis · 2024-12-04T12:43:42Z

samples/matter/smoke_co_alarm/README.rst

+System off configuration
+------------------------
+
+The sample supports optional system off configuration, that turns off the whole system once an ICD device enters the idle state.


Suggested change

The sample supports optional system off configuration, that turns off the whole system once an ICD device enters the idle state.

The sample supports optional system off configuration that turns off the whole system once an ICD device enters the idle state.

peknis · 2024-12-04T12:44:08Z

samples/matter/smoke_co_alarm/README.rst

+------------------------
+
+The sample supports optional system off configuration, that turns off the whole system once an ICD device enters the idle state.
+Turning off the system, instead of putting it to sleep allows the device to achieve much lower power consumption in the idle state.


Suggested change

Turning off the system, instead of putting it to sleep allows the device to achieve much lower power consumption in the idle state.

Turning off the system instead of putting it to sleep allows the device to achieve much lower power consumption in the idle state.

peknis · 2024-12-04T12:46:14Z

samples/matter/smoke_co_alarm/README.rst

+
+The sample supports optional system off configuration, that turns off the whole system once an ICD device enters the idle state.
+Turning off the system, instead of putting it to sleep allows the device to achieve much lower power consumption in the idle state.
+On the other hand, the device wakes up from a sleep state much faster than from the system off, and it sends only Thread data poll frame and Matter data report.


Suggested change

On the other hand, the device wakes up from a sleep state much faster than from the system off, and it sends only Thread data poll frame and Matter data report.

On the other hand, the device wakes up from the sleep state much faster than from the system off, and it sends only a Thread data poll frame and Matter data report.

peknis · 2024-12-04T12:47:06Z

samples/matter/smoke_co_alarm/README.rst

+The sample supports optional system off configuration, that turns off the whole system once an ICD device enters the idle state.
+Turning off the system, instead of putting it to sleep allows the device to achieve much lower power consumption in the idle state.
+On the other hand, the device wakes up from a sleep state much faster than from the system off, and it sends only Thread data poll frame and Matter data report.
+In case of waking up from the system off, the device has to boot the whole system, initialize platform, re-attach to network and send data report every time, what consumes a lot of energy.


Suggested change

In case of waking up from the system off, the device has to boot the whole system, initialize platform, re-attach to network and send data report every time, what consumes a lot of energy.

In case of waking up from the system off, the device has to boot the whole system, initialize platform, re-attach to network, and send data report every time, which consumes a lot of energy.

peknis · 2024-12-04T12:49:40Z

samples/matter/smoke_co_alarm/README.rst

+On the other hand, the device wakes up from a sleep state much faster than from the system off, and it sends only Thread data poll frame and Matter data report.
+In case of waking up from the system off, the device has to boot the whole system, initialize platform, re-attach to network and send data report every time, what consumes a lot of energy.
+
+The usage of system off configuration can be beneficial from the perspective of overall power consumption for the scenarios, when the device has relatively big sleep interval and the system boot happens rarely.


Suggested change

The usage of system off configuration can be beneficial from the perspective of overall power consumption for the scenarios, when the device has relatively big sleep interval and the system boot happens rarely.

Using the system off configuration can be beneficial from the perspective of overall power consumption for scenarios, where the device has relatively long sleep interval and the system boot happens rarely.

peknis · 2024-12-04T12:50:50Z

samples/matter/smoke_co_alarm/README.rst

+In case of waking up from the system off, the device has to boot the whole system, initialize platform, re-attach to network and send data report every time, what consumes a lot of energy.
+
+The usage of system off configuration can be beneficial from the perspective of overall power consumption for the scenarios, when the device has relatively big sleep interval and the system boot happens rarely.
+It was proven by measurements that an ICD device achieves better power consumption with the system off enabled for sleep intervals bigger than 15 minutes.


Suggested change

It was proven by measurements that an ICD device achieves better power consumption with the system off enabled for sleep intervals bigger than 15 minutes.

It was proven by measurements that an ICD device achieves lower power consumption with the system off enabled for sleep intervals longer than 15 minutes.

peknis · 2024-12-04T12:52:48Z

samples/matter/smoke_co_alarm/README.rst

+The usage of system off configuration can be beneficial from the perspective of overall power consumption for the scenarios, when the device has relatively big sleep interval and the system boot happens rarely.
+It was proven by measurements that an ICD device achieves better power consumption with the system off enabled for sleep intervals bigger than 15 minutes.
+
+Additionally, the system off solution disables RAM retention, what results in losing the data that could be potentially stored there, like for example diagnostic logs.


Suggested change

Additionally, the system off solution disables RAM retention, what results in losing the data that could be potentially stored there, like for example diagnostic logs.

The system off solution disables RAM retention, which results in losing data that could be potentially stored in RAM, like for example diagnostic logs.

peknis · 2024-12-04T12:53:05Z

samples/matter/smoke_co_alarm/README.rst

+
+Additionally, the system off solution disables RAM retention, what results in losing the data that could be potentially stored there, like for example diagnostic logs.
+
+This feature is disabled by default, and it is available only for the ``nrf54l15dk/nrf54l15/cpuapp`` target.


Suggested change

This feature is disabled by default, and it is available only for the ``nrf54l15dk/nrf54l15/cpuapp`` target.

This feature is disabled by default, and it is available only for the ``nrf54l15dk/nrf54l15/cpuapp`` board target.

peknis · 2024-12-04T12:55:10Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

@@ -396,6 +396,7 @@ Matter samples
 * :ref:`matter_smoke_co_alarm_sample` sample:

  * Added support for ICD dynamic SIT LIT switching (DSLS).
+  * Added support for system off configuration for the :ref:`zephyr:nrf54l15dk_nrf54l15` target.


Add the changelog entry as a comment to my #19240 and remove it from this PR.

peknis · 2024-12-04T12:56:21Z

samples/matter/smoke_co_alarm/README.rst

+
+This feature is disabled by default, and it is available only for the ``nrf54l15dk/nrf54l15/cpuapp`` target.
+To enable it, set the :kconfig:option:`CONFIG_SAMPLE_MATTER_SYSTEM_OFF` Kconfig option to ``y``.
+You can test the sample configuration that enables system off and configures the device to wake-up every 30 minutes, by applying a dedicated overlay file.


Suggested change

You can test the sample configuration that enables system off and configures the device to wake-up every 30 minutes, by applying a dedicated overlay file.

You can test the sample configuration that enables system off and configures the device to wake-up every 30 minutes by applying a dedicated overlay file.

kkasperczyk-no · 2024-12-04T13:36:02Z

There are too many issues with this change and it needs more work to be solid, so I'm closing the PR for now.

kkasperczyk-no requested review from a team as code owners December 4, 2024 10:45

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Dec 4, 2024

kkasperczyk-no force-pushed the icd_system_off branch from ec7e84e to b530a8e Compare December 4, 2024 10:54

adigie reviewed Dec 4, 2024

View reviewed changes

kkasperczyk-no added the DNM label Dec 4, 2024

nordicjm reviewed Dec 4, 2024

View reviewed changes

kkasperczyk-no force-pushed the icd_system_off branch from b530a8e to fe76cee Compare December 4, 2024 12:08

kkasperczyk-no removed the DNM label Dec 4, 2024

kkasperczyk-no added this to the 2.9.0 milestone Dec 4, 2024

samples: matter: Added system off configuration for smoke CO alarm

3f9e7a6

Added configuration that allows to enable system off for the smoke CO alarm. Signed-off-by: Kamil Kasperczyk <[email protected]>

kkasperczyk-no force-pushed the icd_system_off branch from fe76cee to 3f9e7a6 Compare December 4, 2024 12:27

ArekBalysNordic approved these changes Dec 4, 2024

View reviewed changes

LuDuda approved these changes Dec 4, 2024

View reviewed changes

peknis requested changes Dec 4, 2024

View reviewed changes

kkasperczyk-no removed this from the 2.9.0 milestone Dec 4, 2024

kkasperczyk-no closed this Dec 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: matter: Added system off configuration for smoke CO alarm #19244

samples: matter: Added system off configuration for smoke CO alarm #19244

kkasperczyk-no commented Dec 4, 2024

NordicBuilder commented Dec 4, 2024 •

edited

Loading

NordicBuilder commented Dec 4, 2024

adigie Dec 4, 2024

kkasperczyk-no Dec 4, 2024

nordicjm Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

peknis Dec 4, 2024

kkasperczyk-no commented Dec 4, 2024

	The sample supports optional system off configuration, that turns off the whole system once an ICD device enters the idle state.
	The sample supports optional system off configuration that turns off the whole system once an ICD device enters the idle state.

	Turning off the system, instead of putting it to sleep allows the device to achieve much lower power consumption in the idle state.
	Turning off the system instead of putting it to sleep allows the device to achieve much lower power consumption in the idle state.

	On the other hand, the device wakes up from a sleep state much faster than from the system off, and it sends only Thread data poll frame and Matter data report.
	On the other hand, the device wakes up from the sleep state much faster than from the system off, and it sends only a Thread data poll frame and Matter data report.

	In case of waking up from the system off, the device has to boot the whole system, initialize platform, re-attach to network and send data report every time, what consumes a lot of energy.
	In case of waking up from the system off, the device has to boot the whole system, initialize platform, re-attach to network, and send data report every time, which consumes a lot of energy.

	The usage of system off configuration can be beneficial from the perspective of overall power consumption for the scenarios, when the device has relatively big sleep interval and the system boot happens rarely.
	Using the system off configuration can be beneficial from the perspective of overall power consumption for scenarios, where the device has relatively long sleep interval and the system boot happens rarely.

	It was proven by measurements that an ICD device achieves better power consumption with the system off enabled for sleep intervals bigger than 15 minutes.
	It was proven by measurements that an ICD device achieves lower power consumption with the system off enabled for sleep intervals longer than 15 minutes.

	Additionally, the system off solution disables RAM retention, what results in losing the data that could be potentially stored there, like for example diagnostic logs.
	The system off solution disables RAM retention, which results in losing data that could be potentially stored in RAM, like for example diagnostic logs.


		Additionally, the system off solution disables RAM retention, what results in losing the data that could be potentially stored there, like for example diagnostic logs.

		This feature is disabled by default, and it is available only for the ``nrf54l15dk/nrf54l15/cpuapp`` target.

	You can test the sample configuration that enables system off and configures the device to wake-up every 30 minutes, by applying a dedicated overlay file.
	You can test the sample configuration that enables system off and configures the device to wake-up every 30 minutes by applying a dedicated overlay file.

samples: matter: Added system off configuration for smoke CO alarm #19244

samples: matter: Added system off configuration for smoke CO alarm #19244

Conversation

kkasperczyk-no commented Dec 4, 2024

NordicBuilder commented Dec 4, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Dec 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkasperczyk-no commented Dec 4, 2024

NordicBuilder commented Dec 4, 2024 •

edited

Loading