tests: benchmarks: multicore: Test PM in SPI driver with locks #19037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 3d9a1688a0ff689580ef2260ee2187c541b31888 more detailssdk-nrf:
Github labels
List of changed files detected by CI (10)Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
nordic-segl
force-pushed
the
NRFX-6663_Extend-idle_spim_loopback-with-CS-SPI-lock
branch
from
3a8af08
to
1e20ad1
Compare
nordicjm
requested changes
Nov 25, 2024
| @@ -80,9 +140,26 @@ int main(void) | |||
| test_pass = true; | |||
| timer_expired = false; | |||
|
|
|||
| /* clear edge counters */ | |||
There was a problem hiding this comment.
Suggested change
| /* clear edge counters */ | |
| /* Clear edge counters */ |
Capitalise first letters of comments
There was a problem hiding this comment.
Fixed. However, I left three comments starting from small letter:
while (!timer_expired) {
(...)
} /* while (!timer_expired) */
#if defined(CONFIG_TEST_SPI_RELEASE_BEFORE_SLEEP)
(...)
#else /* defined(CONFIG_TEST_SPI_RELEASE_BEFORE_SLEEP) */
(...)
#endif /* defined(CONFIG_TEST_SPI_RELEASE_BEFORE_SLEEP) */
4a7bc2e
to
2709a0e
Compare
nordic-piks
approved these changes
Nov 25, 2024
nordic-segl
force-pushed
the
NRFX-6663_Extend-idle_spim_loopback-with-CS-SPI-lock
branch
3 times, most recently
from
29cce95
to
c6d3d04
Compare
nordic-pikr
approved these changes
Nov 26, 2024
Extend test that checks: - current consumption in IDLE, S2RAM when SPIM was used; - SPIM works correctly after leaving low power state. Add test suites where SPI is configured with SPI_HOLD_ON_CS and/or SPI_LOCK_ON. Confirm that SPI CS line activation/deactivation is according to: - SPI_HOLD_ON_CS configuration; - spi_release_dt() calls; - not affected by the Device Runtime Power Management. Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
force-pushed
the
NRFX-6663_Extend-idle_spim_loopback-with-CS-SPI-lock
branch
from
c6d3d04
to
3d9a168
Compare
nordicjm
approved these changes
Nov 26, 2024
nordic-segl
deleted the
NRFX-6663_Extend-idle_spim_loopback-with-CS-SPI-lock
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend test that checks:
Add tests suites where SPI is configured with
SPI_HOLD_ON_CS and/or SPI_LOCK_ON.