Not ready for review: TF-M support for building without PSA ITS #19036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Disabling DPLATFORM_DEFAULT_OTP, DPLATFORM_DEFAULT_OTP_WRITEABLE and DPLATFORM_DEFAULT_NV_COUNTERS when CRYPTO_STORAGE_DISABLED is set to remove dependency for NVM driver when ITS is not in use. -Removing hack to falsely give access to non existent service ID TFM_INTERNAL_TRUSTED_STORAGE_SERVICE_ID which was used for TF-M Minimal configuration. ref: NCSDK-13530 Signed-off-by: Frank Audun Kvamtrø <[email protected]>
-Previously we used TFM_PLATFORM_NV_COUNTER_MODULE_DISABLED to signal that NV counters should be enabled when TFM_PROFILE_TYPE_MINIMAL is set. This commit changes the default enablement with a dependency on TFM_PARTITION_INTERNAL_TRUSTED_STORAGE instead. This is done to allow for persistent keys using only the KMU. Ref: NCSDK-13530 Signed-off-by: Frank Audun Kvamtrø <[email protected]>
-This commit feeds the following configurations to disable OTP and ITS when MBEDTLS_PSA_CRYPTO_STORAGE_C is not enabled -DTFM_PARTITION_INTERNAL_TRUSTED_STORAGE=OFF -DPLATFORM_DEFAULT_OTP=OFF -DPLATFORM_DEFAULT_OTP_WRITEABLE=OFF -DPLATFORM_DEFAULT_NV_COUNTERS=OFF The configurations are made to avoid dependency on NVM driver when KMU supports persistent key and generally to be able to optimize for size. Ref: NCSDK-13530 Signed-off-by: Frank Audun Kvamtrø <[email protected]>
-This commit sets up dependency between TFM_ITS_ENCRYPTED and MBEDTLS_PSA_CRYPTO_STORAGE_C and TFM_PARTITION_INTERNAL_TRUSTED_STORAGE to ensure that TFM_ITS_ENCRYPTED is not enabled if one of these are missing. This is used when the persistent keys are stored in KMU. Signed-off-by: Frank Audun Kvamtrø <[email protected]>
-This commit ensure MBEDTLS_PSA_CRYPTO_STORAGE_C is only default enabled for TF-M builds when TFM_PARTITION_INTERNAL_TRUSTED_STORAGE is also enabled. Signed-off-by: Frank Audun Kvamtrø <[email protected]>
-This pulls in TF-M PR nrfconnect#181 which allows for building TF-M without ITS for use-cases where KMU-stored key is sufficient for persistent key support Signed-off-by: Frank Audun Kvamtrø <[email protected]>
github-actions
bot
added
manifest
changelog-entry-required
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:trusted-firmware-m: PR head: f302508a2d5623eb21f99988485980c2606a48e0 more detailstrusted-firmware-m:
sdk-nrf:
Github labels
List of changed files detected by CI (8)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use-cases where KMU provides persistent key support