Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "scroll to npmhub" to the sidebar #171

Merged
merged 4 commits into from
May 29, 2023
Merged

Add "scroll to npmhub" to the sidebar #171

merged 4 commits into from
May 29, 2023

Conversation

Nisgrak
Copy link
Contributor

@Nisgrak Nisgrak commented May 26, 2023

This add the button just before the Readme button, feel free to choose another actual button where set the scroll button.

Fixes the #125
Thanks to #142

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Can you provide a screenshot too?

source/components/ScrollButton.svelte Show resolved Hide resolved
source/npmhub.js Outdated Show resolved Hide resolved
source/npmhub.js Outdated Show resolved Hide resolved
@Nisgrak
Copy link
Contributor Author

Nisgrak commented May 29, 2023

This looks like this:
image

Or in the last position:

image

@fregante
Copy link
Member

Great, thank you! The "last" position looks good

source/npmhub.js Outdated Show resolved Hide resolved
@fregante fregante changed the title Add scroll button Add "scroll to npmhub" to the sidebar May 29, 2023
@fregante fregante merged commit 261203a into npmhub:main May 29, 2023
4 checks passed
@fregante
Copy link
Member

Thank you for the PR!

@fregante fregante linked an issue May 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dependency list is hard to reach
2 participants