Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider equality in publish dist tag check error message #7993

Open
wants to merge 5 commits into
base: latest
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions lib/commands/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,17 @@ class Publish extends BaseCommand {
}
}

const latestVersion = await this.#latestPublishedVersion(resolved, registry)
const newVersion = manifest.version
const { latest: latestVersion, versions } = await this.#registryVersions(resolved, registry)
reggi marked this conversation as resolved.
Show resolved Hide resolved
const latestSemverIsGreater = !!latestVersion && semver.gte(latestVersion, manifest.version)

if (versions.includes(newVersion)) {
throw new Error(`You cannot publish over the previously published versions: ${newVersion}.`)
}

if (latestSemverIsGreater && isDefaultTag) {
/* eslint-disable-next-line max-len */
throw new Error(`Cannot implicitly apply the "latest" tag because published version ${latestVersion} is higher than the new version ${manifest.version}. You must specify a tag using --tag.`)
throw new Error(`Cannot implicitly apply the "latest" tag because published version ${latestVersion} is higher than the new version ${newVersion}. You must specify a tag using --tag.`)
}

const access = opts.access === null ? 'default' : opts.access
Expand Down Expand Up @@ -204,25 +209,27 @@ class Publish extends BaseCommand {
}
}

async #latestPublishedVersion (spec, registry) {
async #registryVersions (spec, registry) {
try {
const packument = await pacote.packument(spec, {
...this.npm.flatOptions,
preferOnline: true,
registry,
})
if (typeof packument?.versions === 'undefined') {
return null
return { versions: [], latest: null }
}
const ordered = Object.keys(packument?.versions)
.flatMap(v => {
const s = new semver.SemVer(v)
return s.prerelease.length > 0 ? [] : s
})
.sort((a, b) => b.compare(a))
return ordered.length >= 1 ? ordered[0].version : null
const latest = ordered.length >= 1 ? ordered[0].version : null
const versions = ordered.map(v => v.version)
return { versions, latest }
reggi marked this conversation as resolved.
Show resolved Hide resolved
} catch (e) {
return null
return { versions: [], latest: null }
}
}

Expand Down
18 changes: 18 additions & 0 deletions test/lib/commands/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -889,6 +889,24 @@ t.test('latest dist tag', (t) => {
}, new Error('Cannot implicitly apply the "latest" tag because published version 100.0.0 is higher than the new version 99.0.0. You must specify a tag using --tag.'))
})

t.test('PREVENTS publish when latest version is SAME AS publishing version', async t => {
const version = '100.0.0'
const { npm, registry } = await loadNpmWithRegistry(t, init(version))
registry.publish(pkg, { noPut: true, packuments })
await t.rejects(async () => {
await npm.exec('publish', [])
}, new Error('You cannot publish over the previously published versions: 100.0.0.'))
})
reggi marked this conversation as resolved.
Show resolved Hide resolved

t.test('PREVENTS publish when publishing version EXISTS ALREADY in the registry', async t => {
const version = '50.0.0'
const { npm, registry } = await loadNpmWithRegistry(t, init(version))
registry.publish(pkg, { noPut: true, packuments })
await t.rejects(async () => {
await npm.exec('publish', [])
}, new Error('You cannot publish over the previously published versions: 50.0.0.'))
})

t.test('ALLOWS publish when latest is HIGHER than publishing version and flag', async t => {
const version = '99.0.0'
const { npm, registry } = await loadNpmWithRegistry(t, {
Expand Down
Loading