fix(worker): delay duration #7496

djabarovgeorge · 2025-01-13T15:15:32Z

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

…duration-limits-for-digest-and-delay-steps-in-code-first

linear · 2025-01-13T15:15:36Z

NV-5144 🐛 Enforce tier duration limits for digest and delay steps in code-first workflows

netlify · 2025-01-13T15:15:51Z

✅ Deploy Preview for dev-web-novu ready!

Name	Link
🔨 Latest commit	`4494044`
🔍 Latest deploy log	https://app.netlify.com/sites/dev-web-novu/deploys/67911112b9b62400085a12f0
😎 Deploy Preview	https://deploy-preview-7496.dashboard.novu-staging.co
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-01-13T15:15:56Z

✅ Deploy Preview for dashboard-v2-novu-staging ready!

Name	Link
🔨 Latest commit	`4494044`
🔍 Latest deploy log	https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/67911112e3fe2f00087b13ae
😎 Deploy Preview	https://deploy-preview-7496.dashboard-v2.novu-staging.co
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…duration-limits-for-digest-and-delay-steps-in-code-first

…est-and-delay-steps-in-code-first

…duration-limits-for-digest-and-delay-steps-in-code-first

djabarovgeorge · 2025-01-15T00:10:44Z

apps/worker/src/app/workflow/usecases/run-job/run-job.usecase.ts

+   * If queueNextJob.execute returns undefined, we stop the workflow.
+   * Otherwise, we continue trying to queue the next job in the chain.
+   */
+  private async tryQueueNextJobs(job: JobEntity): Promise<void> {


this was needed because not we have a possible exception on finally block which is not handled.

for the following workflow SMS => DELAY => IN-APP
the problem is the we handle the delay step (calculate the duration) while we executing the SMS job.
a better solution would be to handle the DELAY step while we execute the DELAY job.
a refactor will take a lot of time and we will need to create backward compatibility support for old jobs as well.

djabarovgeorge · 2025-01-15T00:12:13Z

...cation-generic/src/usecases/tier-restrictions-validate/tier-restrictions-validate.usecase.ts

-    const cronExpression = parseCronExpression(command.cron);
-    const firstTime = cronExpression.next().toDate();
-    const secondTime = cronExpression.next().toDate();
+  private isCronDeltaDeferDurationExceededTier(


i tried to create a simple "smart solution" however on every approach it became very complicated very fast, therefore I created a more simple solution where we validate the next 50 iterations of the crown with an exit if we pass 2 years.

djabarovgeorge · 2025-01-15T00:12:59Z

...cation-generic/src/usecases/tier-restrictions-validate/tier-restrictions-validate.usecase.ts

@@ -142,6 +166,10 @@ const isCronExpression = (cron: string) => {
 };

 const isRegularDeferAction = (command: TierRestrictionsValidateCommand) => {
+  if (command.deferDurationMs) {


a bug we had, where we did not check the deferDurationMs that the worker was passing.

…duration-limits-for-digest-and-delay-steps-in-code-first

…est-and-delay-steps-in-code-first

…mits-for-digest-and-delay-steps-in-code-first' into nv-5144-enforce-tier-duration-limits-for-digest-and-delay-steps-in-code-first

…est-and-delay-steps-in-code-first

scopsy · 2025-01-15T08:01:38Z

apps/worker/src/app/workflow/usecases/add-job/add-job.usecase.ts

    if (errors.length > 0) {
-      const errorMessages = errors?.map((error) => error.message).join(', ');
-      Logger.warn({ errors, jobId: job._id }, errorMessages, LOG_CONTEXT);
+      const uniqueErrors = _.uniq(errors.map((error) => error.message));


In what cases was this not unique?

yes, at the moment if the user has a tier duration error we will duplicate the error to the unit and amount properties so that we will persist it, and the UI will decide how to represent it.
However, we do not need this duplication in the execution detail.

Makes sense, thanks for the explanation 🙏

…duration-limits-for-digest-and-delay-steps-in-code-first

…mits-for-digest-and-delay-steps-in-code-first' into nv-5144-enforce-tier-duration-limits-for-digest-and-delay-steps-in-code-first

…est-and-delay-steps-in-code-first

djabarovgeorge added 3 commits January 13, 2025 10:20

fix(worker): delay duration

035c8ae

Merge remote-tracking branch 'origin/next' into nv-5144-enforce-tier-…

0eac9f8

…duration-limits-for-digest-and-delay-steps-in-code-first

feat(worker): wip tier test

bb25a49

djabarovgeorge temporarily deployed to Linting January 13, 2025 15:15 — with GitHub Actions Inactive

github-actions bot added @novu/worker @novu/api-service labels Jan 13, 2025

feat(api-service): update failed job

7c06365

djabarovgeorge temporarily deployed to Linting January 13, 2025 16:30 — with GitHub Actions Inactive

djabarovgeorge added 2 commits January 13, 2025 19:14

Merge remote-tracking branch 'origin/next' into nv-5144-enforce-tier-…

0c78a43

…duration-limits-for-digest-and-delay-steps-in-code-first

chore(api-service): remove console log

f459747

djabarovgeorge temporarily deployed to Linting January 13, 2025 17:52 — with GitHub Actions Inactive

Merge branch 'next' into nv-5144-enforce-tier-duration-limits-for-dig…

0ca9dd0

…est-and-delay-steps-in-code-first

djabarovgeorge temporarily deployed to Linting January 13, 2025 19:41 — with GitHub Actions Inactive

feat(api-service): add tier test

77d0298

djabarovgeorge temporarily deployed to Linting January 13, 2025 21:40 — with GitHub Actions Inactive

Merge remote-tracking branch 'origin/next' into nv-5144-enforce-tier-…

8a27026

…duration-limits-for-digest-and-delay-steps-in-code-first

djabarovgeorge temporarily deployed to Linting January 14, 2025 09:53 — with GitHub Actions Inactive

djabarovgeorge marked this pull request as ready for review January 14, 2025 23:55

djabarovgeorge commented Jan 15, 2025

View reviewed changes

djabarovgeorge and others added 2 commits January 15, 2025 02:19

Merge remote-tracking branch 'origin/next' into nv-5144-enforce-tier-…

febcd42

…duration-limits-for-digest-and-delay-steps-in-code-first

Merge branch 'next' into nv-5144-enforce-tier-duration-limits-for-dig…

3e57134

…est-and-delay-steps-in-code-first

djabarovgeorge temporarily deployed to Linting January 15, 2025 00:21 — with GitHub Actions Inactive

djabarovgeorge and others added 2 commits January 15, 2025 02:22

Merge remote-tracking branch 'origin/nv-5144-enforce-tier-duration-li…

04ebffa

…mits-for-digest-and-delay-steps-in-code-first' into nv-5144-enforce-tier-duration-limits-for-digest-and-delay-steps-in-code-first

Merge branch 'next' into nv-5144-enforce-tier-duration-limits-for-dig…

ed6f80a

…est-and-delay-steps-in-code-first

djabarovgeorge temporarily deployed to Linting January 20, 2025 08:37 — with GitHub Actions Inactive

scopsy approved these changes Jan 21, 2025

View reviewed changes

djabarovgeorge added 2 commits January 21, 2025 16:13

Merge remote-tracking branch 'origin/next' into nv-5144-enforce-tier-…

7a1105a

…duration-limits-for-digest-and-delay-steps-in-code-first

Merge remote-tracking branch 'origin/nv-5144-enforce-tier-duration-li…

00258c9

…mits-for-digest-and-delay-steps-in-code-first' into nv-5144-enforce-tier-duration-limits-for-digest-and-delay-steps-in-code-first

djabarovgeorge temporarily deployed to Linting January 21, 2025 14:13 — with GitHub Actions Inactive

fix(worker): cron validation

2008d72

djabarovgeorge temporarily deployed to Linting January 21, 2025 18:42 — with GitHub Actions Inactive

Merge branch 'next' into nv-5144-enforce-tier-duration-limits-for-dig…

4494044

…est-and-delay-steps-in-code-first

scopsy temporarily deployed to Linting January 22, 2025 15:39 — with GitHub Actions Inactive

djabarovgeorge merged commit b043aef into next Jan 22, 2025
30 of 31 checks passed

djabarovgeorge deleted the nv-5144-enforce-tier-duration-limits-for-digest-and-delay-steps-in-code-first branch January 22, 2025 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(worker): delay duration #7496

fix(worker): delay duration #7496

djabarovgeorge commented Jan 13, 2025

linear bot commented Jan 13, 2025

netlify bot commented Jan 13, 2025 •

edited

Loading

netlify bot commented Jan 13, 2025 •

edited

Loading

djabarovgeorge Jan 15, 2025

djabarovgeorge Jan 15, 2025

djabarovgeorge Jan 15, 2025

scopsy Jan 15, 2025

djabarovgeorge Jan 21, 2025

scopsy Jan 21, 2025

fix(worker): delay duration #7496

fix(worker): delay duration #7496

Conversation

djabarovgeorge commented Jan 13, 2025

What changed? Why was the change needed?

Screenshots

Related enterprise PR

Special notes for your reviewer

linear bot commented Jan 13, 2025

netlify bot commented Jan 13, 2025 • edited Loading

✅ Deploy Preview for dev-web-novu ready!

netlify bot commented Jan 13, 2025 • edited Loading

✅ Deploy Preview for dashboard-v2-novu-staging ready!

djabarovgeorge Jan 15, 2025

Choose a reason for hiding this comment

djabarovgeorge Jan 15, 2025

Choose a reason for hiding this comment

djabarovgeorge Jan 15, 2025

Choose a reason for hiding this comment

scopsy Jan 15, 2025

Choose a reason for hiding this comment

djabarovgeorge Jan 21, 2025

Choose a reason for hiding this comment

scopsy Jan 21, 2025

Choose a reason for hiding this comment

netlify bot commented Jan 13, 2025 •

edited

Loading

netlify bot commented Jan 13, 2025 •

edited

Loading