Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Ignore this PR - wip remove stale variable examples #7464

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

github-actions bot commented Jan 8, 2025

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Your PR title is: Please Ignore this PR - wip remove stale variable examples
It should be something like: feat(scope): Add fancy new feature

Details:

No release type found in pull request title "Please Ignore this PR - wip remove stale variable examples". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

…-examples

# Conflicts:
#	apps/api/src/app/workflows-v2/util/build-variables.ts
@@ -159,9 +168,10 @@ export class GeneratePreviewUsecase {
finalVariablesExample = previewTemplateData.variablesExample;
}

finalVariablesExample = _.merge(finalVariablesExample, commandVariablesExample || {});
finalVariablesExample = _.merge(finalVariablesExample, commandVariablesExample);
const variablesExample = this.removeStaleVariables(finalVariablesExample, variableSchema);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the main change

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 7b3c74a
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/677ea736c226e10008bdc0a3
😎 Deploy Preview https://deploy-preview-7464.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit 7b3c74a
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/677ea736605b8800086b09c2
😎 Deploy Preview https://deploy-preview-7464.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djabarovgeorge djabarovgeorge changed the title Please Ignore this PR - remove stale variable examples Please Ignore this PR - wip remove stale variable examples Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant