-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please Ignore this PR - wip remove stale variable examples #7464
base: next
Are you sure you want to change the base?
Conversation
Hey there and thank you for opening this pull request! 👋 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Your PR title is: Details: No release type found in pull request title "Please Ignore this PR - wip remove stale variable examples". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/ Available types:
|
…-examples # Conflicts: # apps/api/src/app/workflows-v2/util/build-variables.ts
@@ -159,9 +168,10 @@ export class GeneratePreviewUsecase { | |||
finalVariablesExample = previewTemplateData.variablesExample; | |||
} | |||
|
|||
finalVariablesExample = _.merge(finalVariablesExample, commandVariablesExample || {}); | |||
finalVariablesExample = _.merge(finalVariablesExample, commandVariablesExample); | |||
const variablesExample = this.removeStaleVariables(finalVariablesExample, variableSchema); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the main change
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer