Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api e2e condition fix #5526

Merged
merged 4 commits into from
May 8, 2024
Merged

Api e2e condition fix #5526

merged 4 commits into from
May 8, 2024

Conversation

AliaksandrRyzhou
Copy link
Collaborator

This PR should fix the condition that blocked the tests for the novu/api matrix

image

@AliaksandrRyzhou AliaksandrRyzhou requested a review from a team as a code owner May 8, 2024 14:04
@AliaksandrRyzhou AliaksandrRyzhou requested review from scopsy and Cliftonz and removed request for a team May 8, 2024 14:04
Copy link

netlify bot commented May 8, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 3e759ed
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/663b86e3d59c9f000832e5df
😎 Deploy Preview https://deploy-preview-5526--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 3e759ed
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/663b86e3e4e91c0008271d95
😎 Deploy Preview https://deploy-preview-5526--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Cliftonz Cliftonz merged commit 68e04bb into next May 8, 2024
22 of 24 checks passed
@Cliftonz Cliftonz deleted the api_e2e_condition_fix branch May 8, 2024 14:13
SokratisVidros pushed a commit that referenced this pull request May 13, 2024
* feat(ci): Condition fix

* feat(ci): Move condition on the top

* feat(ci): check_submodule_token without condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants