Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR add a proprientary non-production docker compose file for Novu enterprise #5519

Merged
merged 11 commits into from
May 8, 2024

Conversation

Cliftonz
Copy link
Contributor

@Cliftonz Cliftonz commented May 7, 2024

This is to review adding a docker compose file for enterprise edition so we do not have to manage the code in a word doc.

This could possible go in the enterprise repository but then clients would need access to that repository to run this code.

A boolean option `IS_TRANSLATION_MANAGER_ENABLED` has been added to the enterprise docker compose YAML file, enabling the use of translation manager mode. Additionally, the fallback value in the `useFeatureFlags.ts` hook now checks if a process environment variable exists before defaulting to 'false'. The `.env.example` file and the README document in the Docker enterprise directory were also updated to further clarify the setup process.
This commit includes the addition of the Novu Proprietary Software License to the Docker enterprise directory. The license outlines the terms and conditions for the use of the software.
@Cliftonz Cliftonz requested a review from scopsy May 7, 2024 19:17
@Cliftonz Cliftonz requested a review from a team as a code owner May 7, 2024 19:17
@Cliftonz Cliftonz requested review from AliaksandrRyzhou and removed request for a team May 7, 2024 19:17
@github-actions github-actions bot added the docker label May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 52a26ad
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/663abc0be7572400089c5b61
😎 Deploy Preview https://deploy-preview-5519--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

# Conflicts:
#	docker/enterprise/Readme.md
#	docker/enterprise/docker-compose.enterprise.yml
Copy link

netlify bot commented May 7, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 52a26ad
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/663abc0b0d33f70008242dda
😎 Deploy Preview https://deploy-preview-5519--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This commit modifies the docker-compose file under docker/enterprise directory for adding the 'NOVU_ENTERPRISE' environment variable to 'worker' and 'api' services. Additionally, it updates the image source in the 'web' service. This greatly enhances our Docker capabilities for the enterprise version. Furthermore, changes to the Readme.md file have been made to simplify the setup guide by removing unnecessary steps and updating the docker login command.
The update is to include "decompile" to the .cspell.json file. This ensures that the word "decompile" is recognized as a correctly spelled term by the cspell tool.
The update is to include "decompile" to the .cspell.json file. This ensures that the word "decompile" is recognized as a correctly spelled term by the cspell tool.
Added 'servername' and 'neom' to the list of exceptions in cspell.json. These words will now bypass the spell check, preventing false errors.
The commit introduces additional words to .cspell.json to enrich the spellchecker's vocabulary. This includes "decompile", "servername", "neom", and ".example.env". This update will help reduce incorrect spellcheck flags for these terms.
Some unnecessary entries ('.env.test', 'decompile', 'servername', 'neom', '.example.env') are removed from .cspell.json. Now, it includes only relevant environment files which will simplify the configuration management process.
The term '.example.env' has been moved from one section in .cspell.json to another. The 'neom' spelling rule was also removed. The changes don't effectively add or remove specifics words, but just shift them within the document.
@Cliftonz Cliftonz merged commit ac194ef into next May 8, 2024
23 checks passed
@Cliftonz Cliftonz deleted the enterprise-demo branch May 8, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants