-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This PR add a proprientary non-production docker compose file for Novu enterprise #5519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A boolean option `IS_TRANSLATION_MANAGER_ENABLED` has been added to the enterprise docker compose YAML file, enabling the use of translation manager mode. Additionally, the fallback value in the `useFeatureFlags.ts` hook now checks if a process environment variable exists before defaulting to 'false'. The `.env.example` file and the README document in the Docker enterprise directory were also updated to further clarify the setup process.
This commit includes the addition of the Novu Proprietary Software License to the Docker enterprise directory. The license outlines the terms and conditions for the use of the software.
scopsy
approved these changes
May 7, 2024
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # docker/enterprise/Readme.md # docker/enterprise/docker-compose.enterprise.yml
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This commit modifies the docker-compose file under docker/enterprise directory for adding the 'NOVU_ENTERPRISE' environment variable to 'worker' and 'api' services. Additionally, it updates the image source in the 'web' service. This greatly enhances our Docker capabilities for the enterprise version. Furthermore, changes to the Readme.md file have been made to simplify the setup guide by removing unnecessary steps and updating the docker login command.
The update is to include "decompile" to the .cspell.json file. This ensures that the word "decompile" is recognized as a correctly spelled term by the cspell tool.
The update is to include "decompile" to the .cspell.json file. This ensures that the word "decompile" is recognized as a correctly spelled term by the cspell tool.
Added 'servername' and 'neom' to the list of exceptions in cspell.json. These words will now bypass the spell check, preventing false errors.
The commit introduces additional words to .cspell.json to enrich the spellchecker's vocabulary. This includes "decompile", "servername", "neom", and ".example.env". This update will help reduce incorrect spellcheck flags for these terms.
Some unnecessary entries ('.env.test', 'decompile', 'servername', 'neom', '.example.env') are removed from .cspell.json. Now, it includes only relevant environment files which will simplify the configuration management process.
The term '.example.env' has been moved from one section in .cspell.json to another. The 'neom' spelling rule was also removed. The changes don't effectively add or remove specifics words, but just shift them within the document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to review adding a docker compose file for enterprise edition so we do not have to manage the code in a word doc.
This could possible go in the enterprise repository but then clients would need access to that repository to run this code.