refactor(app-gen,worker): move add job to worker #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
djabarovgeorge
requested review from
a team,
SokratisVidros and
rifont
and removed request for
a team
…-move-add-job-to-worker # Conflicts: # apps/worker/src/app/workflow/workflow.module.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
The addJob use case has been migrated from the application-generic component to the worker application. This improves the separation of concerns by keeping worker-related functionality within the worker itself. Previously, application-generic included addJob to support adding jobs via the API. However, this restriction is no longer applicable.
Some additional validation needed to be done. This is because the application-generic app allows null values with strictNullChecks set as false, while the worker enforces stricter type safety with strictNullChecks set to true.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer