feat: Add support for using embedded images in email providers #5457
Conversation
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -16,6 +16,7 @@ export interface IEmailOptions { | |||
| from?: string; | |||
| text?: string; | |||
| attachments?: IAttachmentOptions[]; | |||
| inlineAttachments?: IAttachmentOptions[]; | |||
There was a problem hiding this comment.
@smbecker we already have a disposition flag passed in the IAttachmentOptions
https://github.com/smbecker/novu/blob/fe8ebc1a57f18626b78340883871ba11a7252c52/packages/stateless/src/lib/template/template.interface.ts#L57
I would prefer if we have a single attachments array, with attachments of different types rather a new array.
What are your thoughts of those 2 approaches?
There was a problem hiding this comment.
Honestly, when I initially kicked off this branch, cid and disposition weren't available several months ago. I finally got some time to finish but I should have checked on recent changes. I'll rework the PR to take advantage of those.
What changed? Why was the change needed?
Given that some of the most used email clients don't support things like base64 images or SVGs as alternatives, using embedded images was the only way that I could get important graphics to display in an email.
https://www.caniemail.com/features/image-base64/
https://www.caniemail.com/features/html-svg/
This is also required to make any progress on #4671
closes #4668