nv-3687-consolidate-provider-npm-packages-into-a-single #5453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatarco
requested review from
a team,
ainouzgali and
djabarovgeorge
and removed request for
a team
tatarco
force-pushed
the
nv-3687-consolidate-provider-npm-packages-into-a-single
branch
from
27a1b72
to
96ce602
Compare
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tatarco
changed the title
tatarco
force-pushed
the
nv-3687-consolidate-provider-npm-packages-into-a-single
branch
3 times, most recently
from
8727f0f
to
136a7d8
Compare
tatarco
changed the title
tatarco
force-pushed
the
nv-3687-consolidate-provider-npm-packages-into-a-single
branch
2 times, most recently
from
62166a1
to
07abeeb
Compare
scopsy
reviewed
Apr 30, 2024
|
Need to make sure we also update our docs for community: https://docs.novu.co/community/add-a-new-provider |
SokratisVidros
approved these changes
Apr 30, 2024
tatarco
force-pushed
the
nv-3687-consolidate-provider-npm-packages-into-a-single
branch
3 times, most recently
from
bf8446d
to
105404c
Compare
tatarco
force-pushed
the
nv-3687-consolidate-provider-npm-packages-into-a-single
branch
3 times, most recently
from
7f53872
to
8007dfd
Compare
tatarco
requested review from
scopsy and
AliaksandrRyzhou
and removed request for
a team
scopsy
reviewed
May 5, 2024
.cspell.json
Outdated
| @@ -731,5 +733,6 @@ | |||
| ".env.local", | |||
| ".env.production", | |||
| ".env.test", | |||
| "./*" | |||
There was a problem hiding this comment.
I guess this one is by mistake?
scopsy
reviewed
May 5, 2024
.gitmodules
Outdated
Comment on lines
1
to
3
| [submodule "enterprise"] | ||
| path = .source | ||
| url = [email protected]:novuhq/packages-enterprise.git |
scopsy
reviewed
May 6, 2024
| @@ -1,6 +1,6 @@ | |||
| packages: | |||
| # all packages in subdirs of packages/ and components/ | |||
| - 'providers/*' | |||
| - 'automation' | |||
There was a problem hiding this comment.
I believe this is also not needed anymore right?
scopsy
force-pushed
the
nv-3687-consolidate-provider-npm-packages-into-a-single
branch
from
2557b3b
to
8b4d499
Compare
This reverts commit f566222.
tatarco
deleted the
nv-3687-consolidate-provider-npm-packages-into-a-single
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
https://linear.app/novu/issue/NV-3687/consolidate-provider-npm-packages-into-a-single-novuproviders-package
https://novu.slack.com/archives/C06V6G9ERFZ
The Chance concluded of multiple parts, they are seperated by commits to make the review easier as this is a Very Big PR
Changes needed to be made to imports, changing '@novu/{providerName} --> '@novu/providers.
Packege.json dependecies needed to be changed to accomedate the new strature.
Screencast of the feature
https://www.loom.com/share/4e932a857ab84a80b211eab01a2373a5
Expand for optional sections
Related enterprise PR
Special notes for your reviewer