chore: Do not lint during e2e run #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
requested review from
Cliftonz and
AliaksandrRyzhou
and removed request for
a team
AliaksandrRyzhou
approved these changes
Apr 25, 2024
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
force-pushed
the
remove_lint_step_from_e2e
branch
from
7e05f42
to
b3c1f57
Compare
Cliftonz
approved these changes
Apr 25, 2024
Linting should run on a PR before merged into next or main.
SokratisVidros
force-pushed
the
remove_lint_step_from_e2e
branch
from
b3c1f57
to
dd1a008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Linting should run on a PR before merged into next or main. It's already in there, for example.