Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add echo usecase and more tracking for getting started #5451

Closed
wants to merge 12 commits into from

Conversation

davidsoderberg
Copy link
Contributor

@davidsoderberg davidsoderberg commented Apr 25, 2024

Screenshot 2024-04-25 at 14 54 44

Copy link

linear bot commented Apr 25, 2024

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 60c9a39
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/662fbb1d6789d800088502ff
😎 Deploy Preview https://deploy-preview-5451--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 60c9a39
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/662fbb1d9d9ec800083383fb
😎 Deploy Preview https://deploy-preview-5451--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@djabarovgeorge djabarovgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me left a small question regarding the event structure.

apps/web/src/pages/get-started/consts/shared.tsx Outdated Show resolved Hide resolved
@davidsoderberg davidsoderberg marked this pull request as ready for review April 26, 2024 03:52
@davidsoderberg davidsoderberg requested a review from a team as a code owner April 26, 2024 03:52
Copy link
Contributor

@antonjoel82 antonjoel82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the new addition, David! The overall outcome of the PR looks great. Asking for changes to avoid accumulating more tech / design debt

@antonjoel82
Copy link
Contributor

One other note -- I think we will want to default to Echo tab instead of in-app which may require a couple tweaks

Copy link
Contributor

@antonjoel82 antonjoel82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants