Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: billing cypress tests #5446

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix: billing cypress tests #5446

merged 2 commits into from
Apr 25, 2024

Conversation

davidsoderberg
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 54befb5
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/6628b488a646490008fe0378
😎 Deploy Preview https://deploy-preview-5446--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 54befb5
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6628b4883b0377000811b19a
😎 Deploy Preview https://deploy-preview-5446--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@antonjoel82 antonjoel82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, and sorry for missing it on Information Architecture!

Comment on lines +94 to +108
cy.intercept('GET', '**/v1/organizations', (request) => {
request.reply((response) => {
if (!response.body.data) {
return response;
}

response.body['data'] = [
{
...response.body.data[0],
apiServiceLevel: 'business',
},
];
return response;
});
}).as('organizations');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Since this is repeated a couple times, perhaps we could wrap all the tests that need it in a shared describe block with its own beforeEach?‏

@davidsoderberg davidsoderberg merged commit b89a003 into next Apr 25, 2024
33 checks passed
@davidsoderberg davidsoderberg deleted the fix-billing-cypress-test branch April 25, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants