Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subscribers): update online status payload error. #5431

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

stanma9107
Copy link

What changed? Why was the change needed?

change online to isOnline to avoid bad request error.

change `online` to `isOnline` to avoid bad request error.
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit d9c46c9
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/662b7829730bfb0008a65d40
😎 Deploy Preview https://deploy-preview-5431--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LetItRock
Copy link
Contributor

@stanma9107 hey, thanks a lot for the fix! 🙌
could you please take a look at failing spec: src/lib/subscribers/subscribers.spec.ts?
don't bother about failing API tests ;)

change `online` to `isOnline`
@BiswaViraj BiswaViraj changed the base branch from v0.24.x to next April 24, 2024 10:34
Copy link

netlify bot commented Apr 24, 2024

👷 Deploy request for dev-web-novu pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d9c46c9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants