feat: Pass customData asm parameters to SendGrid #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
❌ Deploy Preview for novu-design failed. Why did it fail? →
|
LetItRock
reviewed
Apr 19, 2024
Comment on lines
+16
to
+19
| type ASMConfig = { | ||
| groupId: number; | ||
| groupsToDisplay: number[]; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| type ASMConfig = { | |
| groupId: number; | |
| groupsToDisplay: number[]; | |
| }; | |
| type ASMConfig = { | |
| groupId: number | string; | |
| groupsToDisplay: Array<number | string>; | |
| }; |
Comment on lines
+77
to
+85
| const asm = options.customData?.asm as ASMConfig; | ||
| if (asm?.groupId) { | ||
| asm.groupId = parseInt(asm.groupId as any); // Sendgrid expects groupId to be a number | ||
| } | ||
| if (asm?.groupsToDisplay) { | ||
| asm.groupsToDisplay = asm.groupsToDisplay.map((group) => | ||
| parseInt(group as any) | ||
| ); // Sendgrid expects groupsToDisplay to be an array of numbers | ||
| } |
There was a problem hiding this comment.
✏ suggestion: if we would like to allow passing the string or number for both fields, please create a mapper function that will create a new object with appropriate value types like:
private mapAsmOptions(asm: ASMConfig): MailDataRequired['asm'] {
return {
groupId: parseInt(`${asm.groupId}`),
groupsToDisplay: asm.groupsToDisplay.map((group) => parseInt(`${group}`)),
};
}
...
const asm = this.mapAsmOptions(options.customData?.asm);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce?
Looks for an optional
asmparameter incustomDatathat is passed through to the SendGrid API.Why was this change needed?
Addresses #5402