Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom header support for resend, brevo and sendgrid #5343

Merged
merged 2 commits into from Apr 29, 2024

Conversation

jainpawan21
Copy link
Member

@jainpawan21 jainpawan21 commented Mar 29, 2024

What change does this PR introduce?

  1. Add custom header support for few email providers using email overrides

Why was this change needed?

Ref:- https://twitter.com/jain_pawan21/status/1773802143956480136

Other information (Screenshots)

uses:-

await novu.events.trigger("workflowIdentifier", {
  to: "subscriberId",
  payload: {
    customKey: "customValue",
  },
  overrides: {
    email: {
      from: "[email protected]",
      headers: {
        'X-Novu-Custom-Header': 'Novu-Custom-Header-Value',
      },
    }
  },
});

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit a86f2a8
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/6612993b3120920008cd1981
😎 Deploy Preview https://deploy-preview-5343--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit a86f2a8
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/6612993b73163b00088ac656
😎 Deploy Preview https://deploy-preview-5343--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jainpawan21 jainpawan21 changed the title fix: add custom header support for resend, brevo and sendgrid feat: add custom header support for resend, brevo and sendgrid Mar 29, 2024
Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@pontusab
Copy link

pontusab commented Apr 5, 2024

While at it we should also add properties like reply_to https://resend.com/docs/api-reference/emails/send-email let me know if I should make a separate PR

@SokratisVidros
Copy link
Contributor

@jainpawan21 What's the latest update on this PR? Shall we merge?

@jainpawan21
Copy link
Member Author

@jainpawan21 What's the latest update on this PR? Shall we merge?

@SokratisVidros , yes this PR can be merged
Added reply to option in resend provider in #5389

@jainpawan21 jainpawan21 merged commit b1920de into next Apr 29, 2024
25 of 33 checks passed
@jainpawan21 jainpawan21 deleted the feature/custom-header-for-few-email-providers branch April 29, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants