feat(wip): add custom step #5323
Conversation
github-actions
bot
added
@novu/api
@novu/web
@novu/dal
@novu/shared
@novu/worker
labels
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| await this.jobRepository.updateOne( | ||
| { _id: command.job._id, _environmentId: command.environmentId }, | ||
| { | ||
| $set: { 'overrides.customStep': command.chimeraData?.outputs }, |
There was a problem hiding this comment.
we definitely need to find a better place for this data.
| stepType === StepTypeEnum.DELAY || | ||
| stepType === StepTypeEnum.DIGEST || | ||
| stepType === StepTypeEnum.TRIGGER || | ||
| stepType === StepTypeEnum.CUSTOM; |
There was a problem hiding this comment.
Create ActionStepTypeEnum and skip by it
| stepType === StepTypeEnum.DELAY || | |
| stepType === StepTypeEnum.DIGEST || | |
| stepType === StepTypeEnum.TRIGGER || | |
| stepType === StepTypeEnum.CUSTOM; | |
| const skipStep = ActionStepTypeEnum.values.includes((action) => action === stepType) |
|
@coderabbitai review |
WalkthroughThe recent updates primarily focus on enhancing the integration and management of custom steps in the application workflow. The changes include the introduction of a new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @InstrumentUsecase() | ||
| public async execute(command: SendMessageCommand) { | ||
| await this.jobRepository.updateOne( | ||
| { _id: command.job._id, _environmentId: command.environmentId }, | ||
| { | ||
| $set: { 'overrides.customStep': command.chimeraData?.outputs }, | ||
| } | ||
| ); | ||
| } |
There was a problem hiding this comment.
Consider adding error handling for the database operation to manage potential failures gracefully.
public async execute(command: SendMessageCommand) {
try {
await this.jobRepository.updateOne(
{ _id: command.job._id, _environmentId: command.environmentId },
{ $set: { 'overrides.customStep': command.chimeraData?.outputs } }
);
} catch (error) {
// Handle error appropriately
console.error('Failed to execute custom step:', error);
throw error;
}
}Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| @InstrumentUsecase() | |
| public async execute(command: SendMessageCommand) { | |
| await this.jobRepository.updateOne( | |
| { _id: command.job._id, _environmentId: command.environmentId }, | |
| { | |
| $set: { 'overrides.customStep': command.chimeraData?.outputs }, | |
| } | |
| ); | |
| } | |
| @InstrumentUsecase() | |
| public async execute(command: SendMessageCommand) { | |
| try { | |
| await this.jobRepository.updateOne( | |
| { _id: command.job._id, _environmentId: command.environmentId }, | |
| { | |
| $set: { 'overrides.customStep': command.chimeraData?.outputs }, | |
| } | |
| ); | |
| } catch (error) { | |
| // Handle error appropriately | |
| console.error('Failed to execute custom step:', error); | |
| throw error; | |
| } | |
| } |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What change does this PR introduce?
Why was this change needed?
Other information (Screenshots)