Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed font size of created at #3278

Merged
merged 4 commits into from
Apr 30, 2023
Merged

Conversation

ayush4345
Copy link
Contributor

What change does this PR introduce?

image
fixed font size of CreatedAt to 14px similar font size of rest of columns which was earlier 12px

Why was this change needed?

Closes #2743

Other information (Screenshots)

@ayush4345 ayush4345 changed the title fix: fixed font size of createdat fix: fixed font size of created at Apr 24, 2023
Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you <3

@ayush4345
Copy link
Contributor Author

Amazing! Thank you <3

Is it not merged yet ?

@scopsy
Copy link
Contributor

scopsy commented Apr 25, 2023

@ayush4345 not yet, will finalize with failing tests and then will merge. We have some flaky tests issues at the moment

@ayush4345
Copy link
Contributor Author

Do you know why tests are failing. Earlier 2 test failed and now it is 3

@jainpawan21
Copy link
Member

I rerun the test. Now all tests are passing!
Can we now merge this @scopsy

@scopsy scopsy added this pull request to the merge queue Apr 30, 2023
Merged via the queue into novuhq:next with commit d233412 Apr 30, 2023
23 checks passed
@ayush4345 ayush4345 deleted the fontsize-issue branch April 30, 2023 09:21
@ayush4345 ayush4345 restored the fontsize-issue branch April 30, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-1656] ✨ Polishing: Font Sizes are inconsistent
3 participants