Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create custom route class #17

Merged
merged 5 commits into from
Nov 28, 2023
Merged

feat: create custom route class #17

merged 5 commits into from
Nov 28, 2023

Conversation

gabriel-f-santos
Copy link
Contributor

@gabriel-f-santos gabriel-f-santos commented Nov 27, 2023 •
edited by julianolf
Loading

Contain

  • New feature
  • Tests

Details

  • Add custom route to extend FastAPI's APIRoute.
    • This is required once we need to override regular route execution due to different function signatures between Starlette's endpoints and SAM Lambda Function handlers.

@gabriel-f-santos gabriel-f-santos added the enhancement New feature or request label Nov 27, 2023
@gabriel-f-santos gabriel-f-santos requested a review from a team November 27, 2023 14:32
@gabriel-f-santos gabriel-f-santos self-assigned this Nov 27, 2023
julianolf
julianolf reviewed Nov 27, 2023
View reviewed changes
src/routing.py Outdated Show resolved Hide resolved
@gabriel-f-santos gabriel-f-santos requested review from julianolf and a team November 27, 2023 17:53
@julianolf julianolf changed the title feat: inherit APIRoute to customize feat: create custom APIRoute Nov 28, 2023
@julianolf julianolf changed the title feat: create custom APIRoute feat: create custom route class Nov 28, 2023
@julianolf julianolf self-assigned this Nov 28, 2023
@gabriel-f-santos gabriel-f-santos merged commit 3c74bfe into main Nov 28, 2023
5 checks passed
@gabriel-f-santos gabriel-f-santos deleted the feat/add-routes-to-fast-api branch November 28, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luis-Henrique Luis-Henrique Luis-Henrique approved these changes

@julianolf julianolf Awaiting requested review from julianolf

Assignees

@julianolf julianolf

@gabriel-f-santos gabriel-f-santos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabriel-f-santos @julianolf @Luis-Henrique