Merge pull request #18 from noriyotcp/disable-tooltip-on-mobile

Disable tooltip on mobile
noriyotcp · Oct 4, 2024 · bde41ea · bde41ea
2 parents a0cff41 + 6cc718a
commit bde41ea
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/assets/js/detectOS.js b/assets/js/detectOS.js
@@ -32,6 +32,10 @@ export function detectOS() {
  return "Unknown";
 }
 
+export function isDesktop() {
+ return detectOS() === "macOS" || detectOS() === "Windows" || detectOS() === "Linux";
+}
+
 export function isMobile() {
  return detectOS() === "iOS" || detectOS() === "Android";
 }
diff --git a/assets/js/hotkeys.js b/assets/js/hotkeys.js
@@ -1,4 +1,4 @@
-import { isMobile } from "./detectOS.js";
+import { isDesktop } from "./detectOS.js";
 import { setupFocusHotkeys } from "./setupFocusHotkeys.js";
 import { setupSearchHotkeys } from "./setupSearchHotkeys.js";
 import { setupHotkeysPopoverHotkeys } from "./setupHotkeysPopoverHotKeys.js";
@@ -7,9 +7,13 @@ document.addEventListener("DOMContentLoaded", function () {
  // setup to search
  const searchIcon = document.querySelector("button.search__toggle");
  if (searchIcon) {
- if (!isMobile()) {
+ if (isDesktop()) {
  searchIcon.setAttribute("tooltip", "cmd/ctrl + k to open, esc to close");
  searchIcon.setAttribute("tooltip-position", "left");
+ } else {
+ // Disable tooltip on mobile
+ searchIcon.removeAttribute("tooltip");
+ searchIcon.removeAttribute("tooltip-position");
  }
 
  setupSearchHotkeys(searchIcon);